Login to ECR if needed for Local Mode #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 2, 2018 09:34
This makes life easier in our Notebook instances.
Instead of having docker-compose generate a random network each time, use a constant network.
When running local mode the SDK will perform an ECR login if required.
winstonaws
approved these changes
Apr 2, 2018
mvsusp
reviewed
Apr 3, 2018
| @@ -390,7 +409,8 @@ def _build_optml_volumes(self, host, subdirs): | |||
| return volumes | |||
|
|
|||
| def _cleanup(self): | |||
| _check_output('docker network prune -f') | |||
| # we don't need to cleanup anything at the moment | |||
| pass | |||
There was a problem hiding this comment.
Add a TODO (rignacio) here to remove this function later.
There was a problem hiding this comment.
I will not remove this function, I will add to it.
There was a problem hiding this comment.
Them add a TODO (rignacio) here to write this function later :)
| ecr_url = auth['authorizationData'][0]['proxyEndpoint'] | ||
|
|
||
| cmd = "docker login -u AWS -p %s %s" % (token, ecr_url) | ||
| subprocess.check_output(cmd, shell=True) |
There was a problem hiding this comment.
Sometimes we are using _check_output and sometimes we are using subprocess.checkoutput. Can we just use one of them?
There was a problem hiding this comment.
There is a good reason for this. I will probably refactor this anyways.
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Change instance count from 3 to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes:
Use 'sagemaker-local' docker network for LocalMode