-
Notifications
You must be signed in to change notification settings - Fork 1.2k
documentation: Add processing readthedocs #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a few small comments from me. looks good!
@@ -377,3 +378,13 @@ For more information, see `Amazon SageMaker Debugger`_. | |||
|
|||
.. _Amazon SageMaker Debugger: https://sagemaker.readthedocs.io/en/stable/amazon_sagemaker_debugger.html | |||
|
|||
|
|||
Amazon SageMaker Processing | |||
--------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: make the line of dashes the same length as the line of text
same with the other headers
You can run notebooks on Amazon SageMaker that demonstrate end-to-end examples of using processing jobs to perform data pre-processing, feature engineering and model evaluation steps. See `Learn More`_ at the bottom of this page for more in-depth information. | ||
|
||
|
||
Data Pre-Processing and Model Evaluation with Scikit-Learn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scikit-learn's docs leave "scikit-learn" lowercase as far as I can tell while Uncyclopedia capitalizes it as "Scikit-learn"
sklearn_processor = SKLearnProcessor(framework_version='0.20.0', | ||
role='[Your SageMaker-compatible IAM role]', | ||
instance_type='ml.m5.xlarge', | ||
instance_count=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent indentation
same below
from sagemaker.sklearn.processing import SKLearnProcessor | ||
|
||
sklearn_processor = SKLearnProcessor(framework_version='0.20.0', | ||
role='[Your SageMaker-compatible IAM role]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might remove the brackets from the role placeholder lest anyone think it should be a list 😂
Hey @laurenyu, Unfortunately I don’t have access to a computer (and won’t until 2/3). Would you be able to merge this in now, and I can address comments when I return? |
@andremoeller waiting on @aws-rbs to do his edit pass |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
talked to @aws-rbs. He'll do his edits in a follow-up PR.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
None
Description of changes:
Adds Processing ReadTheDocs
Testing done:
tox -e sphinx
to build.open doc/_build/html/index.html
to review.Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.