Skip to content

change: remove NEO_ALLOWED_TARGET_INSTANCE_FAMILY #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020
Merged

change: remove NEO_ALLOWED_TARGET_INSTANCE_FAMILY #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/sagemaker/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
)
from sagemaker.job import _Job
from sagemaker.local import LocalSession
from sagemaker.model import Model, NEO_ALLOWED_TARGET_INSTANCE_FAMILY, NEO_ALLOWED_FRAMEWORKS
from sagemaker.model import Model, NEO_ALLOWED_FRAMEWORKS
from sagemaker.model import (
SCRIPT_PARAM_NAME,
DIR_PARAM_NAME,
Expand Down Expand Up @@ -511,11 +511,6 @@ def compile_model(
sagemaker.model.Model: A SageMaker ``Model`` object. See
:func:`~sagemaker.model.Model` for full details.
"""
if target_instance_family not in NEO_ALLOWED_TARGET_INSTANCE_FAMILY:
raise ValueError(
"Please use valid target_instance_family,"
"allowed values: {}".format(NEO_ALLOWED_TARGET_INSTANCE_FAMILY)
)
if framework and framework not in NEO_ALLOWED_FRAMEWORKS:
raise ValueError(
"Please use valid framework, allowed values: {}".format(NEO_ALLOWED_FRAMEWORKS)
Expand Down
21 changes: 0 additions & 21 deletions src/sagemaker/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,27 +24,6 @@

LOGGER = logging.getLogger("sagemaker")

NEO_ALLOWED_TARGET_INSTANCE_FAMILY = set(
[
"ml_c5",
"ml_m5",
"ml_c4",
"ml_m4",
"jetson_tx1",
"jetson_tx2",
"jetson_nano",
"ml_p2",
"ml_p3",
"deeplens",
"rasp3b",
"rk3288",
"rk3399",
"sbe_c",
"aisage",
"qcs603",
"qcs605",
]
)
NEO_ALLOWED_FRAMEWORKS = set(["mxnet", "tensorflow", "keras", "pytorch", "onnx", "xgboost"])

NEO_IMAGE_ACCOUNT = {
Expand Down