Increase timeout limit to 20 minutes for tf_cifar test to avoid tests… #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timing out using tf 1.6.0
yangaws
requested review from
iquintero,
andremoeller,
laurenyu and
ChoiByungWook
laurenyu
approved these changes
Apr 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 36 36
Lines 2438 2438
=======================================
Hits 2201 2201
Misses 237 237Continue to review full report at Codecov.
|
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
TF IRIS BYOM is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our canary caught tf_cifar tests failed occasionally for timeout in tf 1.6. Increase the timeout to 20 minutes to fix it.
The increase of 5 minute should be enough since we now only get timeout approximately 1 out of 5 runs.