Skip to content

infra: configure pylint to recognize boto3 and botocore as third-party imports #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ int-import-graph=
known-standard-library=

# Force import order to recognize a module as part of a third party library.
known-third-party=enchant
known-third-party=boto3,botocore,enchant

# Analyse import fallback blocks. This can be used to support both Python 2 and
# 3 compatible code, which means that the block might have code that exists
Expand Down
3 changes: 2 additions & 1 deletion src/sagemaker/model_monitor/monitoring_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@
import os
import uuid

from botocore.exceptions import ClientError

from sagemaker.session import Session
from sagemaker.s3 import S3Downloader
from sagemaker.s3 import S3Uploader
from botocore.exceptions import ClientError

NO_SUCH_KEY_CODE = "NoSuchKey"

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
import time
import warnings

import six
import boto3
import botocore.config
from botocore.exceptions import ClientError
import six

import sagemaker.logs
from sagemaker import vpc_utils
Expand Down