fix: make repack_model only removes py file when new entry_point provided #1352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently in the
utils.repack_model
function, this line will remove all files inmodel_dir/code
, which may containrequirements.txt
. In the documentation, however, we instruct customer to putrequirements.txt
into the model tarbal (https://sagemaker.readthedocs.io/en/stable/using_pytorch.html#using-third-party-libraries), which then will be removed if a newentry_point
is provided:sagemaker-python-sdk/src/sagemaker/pytorch/model.py
Line 200 in 4ef5386
Description of changes:
Inspecting files in
model_dir/code
and only remove python files.Testing done:
unit test
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.