Skip to content

fix: correct local mode behavior for CN regions #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 6, 2020
Merged

fix: correct local mode behavior for CN regions #1390

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6fb795
fix: correct local mode behavior for CN regions
knakad Apr 6, 2020
ca85263
Merge branch 'master' into 20200406-local-mode-fix
knakad Apr 6, 2020
110f799
readd group to pattern to prevent static index error in pattern matching
knakad Apr 6, 2020
04d0205
Merge remote-tracking branch 'origin/20200406-local-mode-fix' into 20…
knakad Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
from six.moves.urllib import parse


ECR_URI_PATTERN = r"^(\d+)(\.)dkr(\.)ecr(\.)(.+)(\.)(amazonaws.com|c2s.ic.gov)(/)(.*:.*)$"
ECR_URI_PATTERN = r"^(\d+)(\.)dkr(\.)ecr(\.)(.+)(\.)(.*)(/)(.*:.*)$"
MAX_BUCKET_PATHS_COUNT = 5
S3_PREFIX = "s3://"
HTTP_PREFIX = "http://"
Expand Down