Skip to content

infra: add TF batch transform integ test with KMS and network isolation #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2020
Merged

infra: add TF batch transform integ test with KMS and network isolation #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61d42c0
infra: add TF batch transform integ test with KMS and network isolation
laurenyu Apr 14, 2020
1a2ca4d
commit new input file
laurenyu Apr 15, 2020
0c306bf
Merge branch 'master' into tf-batch-integ-test
laurenyu Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sagemaker/tensorflow/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,9 @@ def create_model(
if "name" not in kwargs:
kwargs["name"] = self._current_job_name

if "enable_network_isolation" not in kwargs:
kwargs["enable_network_isolation"] = self.enable_network_isolation()

if endpoint_type == "tensorflow-serving" or self._script_mode_enabled():
return self._create_tfs_model(
role=role,
Expand Down Expand Up @@ -630,7 +633,6 @@ def _create_tfs_model(
entry_point=entry_point,
source_dir=source_dir,
dependencies=dependencies,
enable_network_isolation=self.enable_network_isolation(),
**kwargs
)

Expand Down Expand Up @@ -660,7 +662,6 @@ def _create_default_model(
sagemaker_session=self.sagemaker_session,
vpc_config=self.get_vpc_config(vpc_config_override),
dependencies=dependencies or self.dependencies,
enable_network_isolation=self.enable_network_isolation(),
**kwargs
)

Expand Down
Loading