Skip to content

infra: remove TF from optional dependencies #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,34 +14,7 @@
from __future__ import absolute_import

import pkg_resources
import sys
from datetime import datetime
from unittest.mock import MagicMock


class Mock(MagicMock):
@classmethod
def __getattr__(cls, name):
"""
Args:
name:
"""
if name == "__version__":
return "1.4.0"
else:
return MagicMock()


MOCK_MODULES = [
"tensorflow",
"tensorflow.core",
"tensorflow.core.framework",
"tensorflow.python",
"tensorflow.python.framework",
"tensorflow_serving",
"tensorflow_serving.apis",
]
sys.modules.update((mod_name, Mock()) for mod_name in MOCK_MODULES)

project = u"sagemaker"
version = pkg_resources.require(project)[0].version
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def read_version():
# Declare minimal set for installation
required_packages = [
"boto3>=1.13.6",
"google-pasta",
"numpy>=1.9.0",
"protobuf>=3.1",
"protobuf3-to-dict>=0.1.5",
Expand All @@ -51,7 +52,6 @@ def read_version():
"docker-compose>=1.25.2",
"PyYAML>=5.3, <6", # PyYAML version has to match docker-compose requirements
],
"tensorflow": ["tensorflow>=1.3.0"],
"scipy": ["scipy>=0.19.0"],
}
# Meta dependency groups
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ passenv =
# Can be used to specify which tests to run, e.g.: tox -- -s
commands =
coverage run --source sagemaker -m pytest {posargs}
{env:IGNORE_COVERAGE:} coverage report --fail-under=86 --omit */tensorflow/tensorflow_serving/*
{env:IGNORE_COVERAGE:} coverage report --fail-under=86
extras = test

[testenv:flake8]
Expand Down