Merge branch 'master' into zwei #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chuyang Deng <[email protected]> Co-authored-by: Lauren Yu <[email protected]>
This was a workaround while waiting for rules_config to be released to PyPI.
This commit also consolidates the doc dependencies to doc/requirements.txt, removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0.
* prepare release v1.65.1 * update development version to v1.65.2.dev0 * doc: document that Local Mode + local code doesn't support dependencies arg (aws#1608) * infra: upgrade Sphinx to 3.1.1 (aws#1605) This commit also consolidates the doc dependencies to doc/requirements.txt, removes some unnecessary dependencies, and upgrades sphinx-rtd-theme to 0.5.0. * feature: add py38 to buildspecs Co-authored-by: ci <ci> Co-authored-by: Lauren Yu <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
metrizable
approved these changes
Jun 26, 2020
Comment on lines
+53
to
54
| "and have also enabled parameter server for distributed training. " | ||
| "Distributed training with the default parameter server configuration will not " |
There was a problem hiding this comment.
Should this have a comma after the "If" portion?
Suggested change
| "and have also enabled parameter server for distributed training. " | |
| "Distributed training with the default parameter server configuration will not " | |
| "and have also enabled parameter server for distributed training, " | |
| "distributed training with the default parameter server configuration will not " |
There was a problem hiding this comment.
I want to keep this a pure merge commit, so fixed it in #1637
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merging these changes from
masterintozweiTesting done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.