Skip to content

fix: Nullable fields in processing_config #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2020
+8 −5
Merged

fix: Nullable fields in processing_config #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/sagemaker/workflow/airflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,10 +1154,11 @@ def processing_config(
)
config["ProcessingResources"] = processing_resources

stopping_condition = sagemaker.processing.ProcessingJob.prepare_stopping_condition(
processor.max_runtime_in_seconds
)
config["StoppingCondition"] = stopping_condition
if processor.max_runtime_in_seconds is not None:
stopping_condition = sagemaker.processing.ProcessingJob.prepare_stopping_condition(
processor.max_runtime_in_seconds
)
config["StoppingCondition"] = stopping_condition

if processor.tags is not None:
config["Tags"] = processor.tags
Expand All @@ -1174,4 +1175,6 @@ def input_output_list_converter(object_list):
Returns:
List of dicts
"""
return [obj._to_request_dict() for obj in object_list]
if object_list:
return [obj._to_request_dict() for obj in object_list]
return object_list