Skip to content

Update tf serving api #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2018
Merged

Update tf serving api #181

merged 5 commits into from
May 11, 2018

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented May 10, 2018

Issue #, if available:
#179
#139

Description of changes:
Updated tf serving protobuf messages to 1.7.0

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested a review from laurenyu May 10, 2018 23:43
@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          38       38           
  Lines        2593     2593           
=======================================
  Hits         2351     2351           
  Misses        242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d974d4b...7f149cf. Read the comment docs.

CHANGELOG.rst Outdated
@@ -1,4 +1,4 @@
=========
=========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the extra indent?

Copy link
Contributor

@iquintero iquintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove 'mvs' from the PR name. This is what the commit will look like when you merge unless you change it. So better change it now :)

CHANGELOG.rst Outdated
@@ -1,4 +1,4 @@
=========
=========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@mvsusp mvsusp changed the title Mvs update tf serving api Update tf serving api May 11, 2018
@mvsusp mvsusp merged commit 8738b21 into aws:master May 11, 2018
@mvsusp mvsusp deleted the mvs-update-tf-serving-api branch May 11, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants