Skip to content

fix: check ast node on later renamers for cli v2 updater #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sagemaker/cli/compatibility/v2/modifiers/image_uris.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,10 @@ def node_should_be_modified(self, node):
Returns:
bool: If the import statement imports ``get_image_uri`` from the correct module.
"""
return node.module in GET_IMAGE_URI_NAMESPACES and any(
name.name == GET_IMAGE_URI_NAME for name in node.names
return (
node is not None
and node.module in GET_IMAGE_URI_NAMESPACES
and any(name.name == GET_IMAGE_URI_NAME for name in node.names)
)

def modify_node(self, node):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"). You
# may not use this file except in compliance with the License. A copy of
# the License is located at
#
# http://aws.amazon.com/apache2.0/
#
# or in the "license" file accompanying this file. This file is
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import textwrap

import pasta
import pytest

from sagemaker.cli.compatibility.v2.ast_transformer import ASTTransformer


@pytest.fixture
def input_code():
return textwrap.dedent(
"""
from sagemaker.predictor import csv_serializer

csv_serializer.__doc__
"""
)


@pytest.fixture
def output_code():
return textwrap.dedent(
"""
from sagemaker import serializers

serializers.CSVSerializer().__doc__
"""
)


def test_simple_script(input_code, output_code):
input_ast = pasta.parse(input_code)
output_ast = ASTTransformer().visit(input_ast)
assert pasta.dump(output_ast) == output_code