feature: add xgboost framework version 1.2-1 #1899

edwardjkim · 2020-09-16T23:32:46Z

Description of changes:
This PR adds Sagemaker XGBoost version 1.2-1. In 1.2-1 we drop the suffix -cpu-py3 since the image supports both CPU and GPU.

Testing done:
tox tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-09-16T23:35:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 78cdffd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

edwardjkim · 2020-09-16T23:43:00Z

@iyerr3 Can you review the PR? Specifically the error message here: https://github.com/aws/sagemaker-python-sdk/pull/1899/files#diff-42337fa10ff460fd141c4f009a88db73R17

sagemaker-bot · 2020-09-17T00:08:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 78cdffd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:09:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 761e1a8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:11:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 78cdffd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:22:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f2c2507
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:47:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 761e1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:50:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 761e1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:52:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2c2507
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T00:55:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f2c2507
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T01:25:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f2c2507
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chuyang-deng · 2020-09-17T16:54:32Z

src/sagemaker/image_uri_config/xgboost.json

@@ -125,6 +125,35 @@
                "us-west-2": "246618743249"
            },
            "repository": "sagemaker-xgboost"
+        },
+        "1.2-1": {


Did you also update the version_aliases on this file?

@edwardjkim We should add 1.2 as an alias.
@ChuyangDeng we can hold off on the other alias PR if there are conflicts with this PR.

@iyerr3 Are we sure that we want to add 1.2 as an alias? Doesn't that kind of defeat the purpose of having the container version -1 in 1.2-1?

@ChuyangDeng I talked to Rahul offline. We are going to hold off on version_aliases and revisit later.

edwardjkim · 2020-09-17T22:03:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr

Commit ID: f2c2507

Result: FAILED

Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ChuyangDeng I'm confused. Why is 'repository' getting passed to xgboost_latest_py_version?

sagemaker-bot · 2020-09-21T22:36:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9141233
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:02:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9141233
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:02:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9141233
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:13:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f02bdf9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:14:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9141233
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:32:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f02bdf9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:34:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f02bdf9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-21T23:44:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f02bdf9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-28T20:34:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1eae9d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-28T20:34:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1eae9d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-28T20:34:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1eae9d5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-28T20:58:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1eae9d5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-29T20:57:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bd502c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-29T21:17:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bd502c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-29T21:29:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bd502c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-29T22:56:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bd502c1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feature: add xgboost framework version 1.2-1 * Add copywrite to xgboost utils file * Add absolute_import to xgboost utils file * Remove xgboost_latest_py_version fixture from airflow config test Co-authored-by: Chuyang <[email protected]> Co-authored-by: icywang86rui <[email protected]>

chuyang-deng suggested changes Sep 17, 2020

View reviewed changes

edwardjkim added 3 commits September 21, 2020 22:15

feature: add xgboost framework version 1.2-1

d28ddc4

Add copywrite to xgboost utils file

2f7d94d

Add absolute_import to xgboost utils file

e7bfaa1

edwardjkim force-pushed the xgboost_1.2 branch from f2c2507 to 9141233 Compare September 21, 2020 22:34

Remove xgboost_latest_py_version fixture from airflow config test

f02bdf9

edwardjkim force-pushed the xgboost_1.2 branch from 9141233 to f02bdf9 Compare September 21, 2020 23:05

edwardjkim requested a review from chuyang-deng September 21, 2020 23:51

edwardjkim mentioned this pull request Sep 22, 2020

Bump XGBoost to 1.2 and Sagemaker SDK to v2 in XGBoost abalone notebooks aws/amazon-sagemaker-examples#1562

Merged

chuyang-deng approved these changes Sep 28, 2020

View reviewed changes

Merge branch 'master' into xgboost_1.2

1eae9d5

Merge branch 'master' into xgboost_1.2

bd502c1

icywang86rui merged commit 74ea308 into aws:master Sep 30, 2020

feature: add xgboost framework version 1.2-1 #1899

feature: add xgboost framework version 1.2-1 #1899

Uh oh!

Conversation

edwardjkim commented Sep 16, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Sep 16, 2020

AWS CodeBuild CI Report

Uh oh!

edwardjkim commented Sep 16, 2020

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

chuyang-deng Sep 17, 2020

Choose a reason for hiding this comment

Uh oh!

iyerr3 Sep 17, 2020

Choose a reason for hiding this comment

Uh oh!

edwardjkim Sep 17, 2020

Choose a reason for hiding this comment

Uh oh!

edwardjkim Sep 18, 2020

Choose a reason for hiding this comment

Uh oh!

edwardjkim commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 21, 2020

AWS CodeBuild CI Report

Uh oh!