fix: blazingtext tag and upgrade sparkml version #1904

chuyang-deng · 2020-09-17T16:52:02Z

Issue #, if available:
image_uris should retrieve blazingtext:latest but instead blazingtext:1 is retrieved: aws/amazon-sagemaker-examples#1392

Also spark-ml-serving is upgraded to 2.4

Description of changes:

update blazingtext version from "1" to "latest"
upgrade spark-ml-serving version to 2.4

Testing done:
tox -e py38 -- tests/unit/sagemaker/image_uris

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-09-17T17:01:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e8ffe70
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T17:17:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e8ffe70
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T17:32:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e8ffe70
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T18:23:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e8ffe70
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T18:30:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f031c53
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T18:56:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f031c53
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T19:07:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f031c53
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T20:19:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f031c53
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T22:35:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d6d1012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T22:53:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d6d1012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T23:09:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d6d1012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-09-17T23:58:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d6d1012
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iyerr3 · 2020-09-18T05:38:45Z

src/sagemaker/image_uri_config/blazingtext.json

@@ -1,7 +1,7 @@
 {
    "scope": ["inference", "training"],
    "versions": {
-        "1": {


This should remain as 1 and we should add latest as an alias to 1. That's the policy for all 1P algorithms.

metrizable · 2020-09-18T16:33:56Z

tests/unit/sagemaker/image_uris/test_algos.py

@@ -177,7 +177,8 @@ def test_algo_uris(algo):

    for region in regions.regions():
        uri = image_uris.retrieve(algo, region)
-        assert expected_uris.algo_uri(algo, accounts[region], region) == uri
+        version = "latest" if algo == "blazingtext" else 1


should be a str?

Suggested change

version = "latest" if algo == "blazingtext" else 1

version = "latest" if algo == "blazingtext" else "1"

To reiterate point from my other comment: nothing special in BlazingText wrt to versioning. It should be same as other 1P algos

chuyang-deng · 2020-09-22T23:43:40Z

closing per #1917

fix: blazingtext tag and upgrade sparkml version

e8ffe70

update sparkml default version

f031c53

fix pylint error

d6d1012

iyerr3 reviewed Sep 18, 2020

View reviewed changes

metrizable reviewed Sep 18, 2020

View reviewed changes

chuyang-deng mentioned this pull request Sep 22, 2020

feature: Add SDK support for SparkML Serving Container version 2.4 #1917

Merged

7 tasks

chuyang-deng closed this Sep 22, 2020

	version = "latest" if algo == "blazingtext" else 1
	version = "latest" if algo == "blazingtext" else "1"

fix: blazingtext tag and upgrade sparkml version #1904

fix: blazingtext tag and upgrade sparkml version #1904

Uh oh!

Conversation

chuyang-deng commented Sep 17, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 17, 2020

AWS CodeBuild CI Report

Uh oh!

iyerr3 Sep 18, 2020

Choose a reason for hiding this comment

Uh oh!

metrizable Sep 18, 2020

Choose a reason for hiding this comment

Uh oh!

iyerr3 Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuyang-deng commented Sep 22, 2020

Uh oh!

Uh oh!

iyerr3 Sep 18, 2020 •

edited

Loading