change: include workflow integ tests with clarify and debugger enabled #2024

rohangujarathi · 2020-12-10T10:47:33Z

Issue #, if available:
Added integ tests for workflow with clarify and debugger configuration

Description of changes:

tests/integ/test_workflow_with_clarify.py: Executes a pipeline with processing step that uses analysis config with pre_training_bias and post_training bias. Pipeline also runs a condition step based on the processing step bias result.
tests/integ/test_workflow.py: Executes a pipeline with training step with rules and debugger hook config configured

Testing done:
Executed both the integ tests locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-12-10T10:49:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d05ee41
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T10:56:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d05ee41
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T11:29:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d05ee41
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T11:43:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d05ee41
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/integ/test_workflow.py

tests/integ/test_workflow_with_clarify.py

Co-authored-by: Eric Johnson <[email protected]>

sagemaker-bot · 2020-12-10T21:05:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d596f11
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T21:06:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d596f11
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T21:07:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d596f11
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-10T21:57:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d596f11
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-11T10:01:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7c46f8a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-11T10:08:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7c46f8a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-11T10:42:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7c46f8a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-11T10:57:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7c46f8a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/integ/test_workflow_with_clarify.py

sagemaker-bot · 2020-12-14T18:29:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3557ec4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T18:36:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3557ec4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T19:10:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3557ec4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T19:23:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3557ec4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T20:45:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 318d27c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T20:45:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 318d27c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T20:50:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eafbb65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T20:50:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eafbb65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:19:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d4b9d08
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:20:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d4b9d08
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:21:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eafbb65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:22:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 318d27c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:23:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 318d27c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:23:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eafbb65
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:45:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d4b9d08
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:57:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0a2dc63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:58:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0a2dc63
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T21:59:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d4b9d08
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T22:29:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0a2dc63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-14T22:35:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0a2dc63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-15T00:47:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0a2dc63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/integ/test_workflow_with_clarify.py

Co-authored-by: Eric Johnson <[email protected]>

metrizable

looks good! thanks for the contribution!

sagemaker-bot · 2020-12-15T19:48:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eb5382a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-15T19:55:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eb5382a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-15T20:26:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eb5382a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-15T20:45:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: eb5382a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: include workflow integ tests with clarify and debugger enabled

d05ee41

rohangujarathi requested review from metrizable and danabens December 10, 2020 10:51

rohangujarathi requested a review from owen-t December 10, 2020 18:11

owen-t previously approved these changes Dec 10, 2020

View reviewed changes

metrizable suggested changes Dec 10, 2020

View reviewed changes

tests/integ/test_workflow.py Outdated Show resolved Hide resolved

tests/integ/test_workflow.py Outdated Show resolved Hide resolved

tests/integ/test_workflow.py Outdated Show resolved Hide resolved

tests/integ/test_workflow_with_clarify.py Show resolved Hide resolved

avoid use of os.path.join for s3 paths

d596f11

Co-authored-by: Eric Johnson <[email protected]>

rohangujarathi dismissed owen-t’s stale review via d596f11 December 10, 2020 21:03

remove hardcoded pytorch framework and py_version

7c46f8a

rohangujarathi requested a review from metrizable December 11, 2020 10:03

danabens reviewed Dec 14, 2020

View reviewed changes

tests/integ/test_workflow_with_clarify.py Outdated Show resolved Hide resolved

Don't override analysis config

3557ec4

rohangujarathi requested a review from danabens December 14, 2020 18:39

danabens previously approved these changes Dec 14, 2020

View reviewed changes

Merge branch 'master' into master

d4b9d08

correct black failure

0a2dc63

rohangujarathi requested a review from metrizable December 15, 2020 01:15

metrizable reviewed Dec 15, 2020

View reviewed changes

tests/integ/test_workflow_with_clarify.py Outdated Show resolved Hide resolved

Update tests/integ/test_workflow_with_clarify.py

eb5382a

Co-authored-by: Eric Johnson <[email protected]>

metrizable approved these changes Dec 15, 2020

View reviewed changes

danabens approved these changes Dec 15, 2020

View reviewed changes

icywang86rui approved these changes Dec 15, 2020

View reviewed changes

icywang86rui merged commit e8deeb3 into aws:master Dec 15, 2020

change: include workflow integ tests with clarify and debugger enabled #2024

change: include workflow integ tests with clarify and debugger enabled #2024

Uh oh!

Conversation

rohangujarathi commented Dec 10, 2020

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 10, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 11, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 11, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 11, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 11, 2020

AWS CodeBuild CI Report

Uh oh!

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2020

AWS CodeBuild CI Report

Uh oh!