Skip to content

Add PT 1.7.1 support to smddp #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add PT 1.7.1 support to smddp #2039

wants to merge 3 commits into from

Conversation

ChaiBapchya
Copy link
Contributor

Don't merge until PT1.7.1-cu11 training DLC released with SMDDP support
Issue #, if available:

Description of changes:
Allowlist 1.7.1 PT framework version as a supported SMDDP framework version

Testing done:
Ongoing

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ChaiBapchya ChaiBapchya marked this pull request as draft December 14, 2020 21:48
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bcbca31
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bcbca31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: bcbca31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: bcbca31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ChaiBapchya ChaiBapchya changed the title [DO-NOT-MERGE] Add PT 1.7.1 support to smddp Add PT 1.7.1 support to smddp Feb 18, 2021
@ChaiBapchya
Copy link
Contributor Author

Allow-list of PT 1.7 can only be done once SM Python SDK has the mapping of framework_version to appropriate DLC image URI

PyTorch(framework_version='1.7.0.', ..)

to
https://github.com/aws/deep-learning-containers/releases/tag/v1.0-pt-1.7.1-tr-py36

@ChaiBapchya ChaiBapchya marked this pull request as ready for review February 18, 2021 00:17
@ChaiBapchya
Copy link
Contributor Author

@saimidu @metrizable @ChoiByungWook FYI

cc @rondogency

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1d68db8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 1d68db8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d68db8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 1d68db8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 1d68db8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ChoiByungWook
ChoiByungWook reviewed Mar 3, 2021
View reviewed changes
tests/unit/test_fw_utils.py
@@ -632,6 +632,7 @@ def test_validate_smdataparallel_args_not_raises():
(None, None, None, None, smdataparallel_disabled),
("ml.p3.16xlarge", "tensorflow", "2.3.1", "py3", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.6.0", "py3", smdataparallel_enabled),
("ml.p3.16xlarge", "pytorch", "1.7.0", "py3", smdataparallel_enabled),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.7.1?

@ChoiByungWook ChoiByungWook self-assigned this Mar 3, 2021
@ChoiByungWook
Copy link
Contributor

Pending: #2185

@ChoiByungWook ChoiByungWook mentioned this pull request Mar 3, 2021
Merged
7 tasks
@ChoiByungWook
Copy link
Contributor

Adding changes in this PR into: #2185

When updating the PyTorch 1.7.1 configuration, the integration test for Data Parallel fail due to the conditional mapping for supported versions and the conftest using the latest version.

This will need to be decoupled in the Python SDK tests.

@ChaiBapchya ChaiBapchya deleted the pt_171_smddp branch March 29, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChoiByungWook ChoiByungWook ChoiByungWook left review comments

Assignees

@ChoiByungWook ChoiByungWook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaiBapchya @sagemaker-bot @ChoiByungWook