feat: Add support for actions in debugger rules. #2047

ndodda-amazon · 2020-12-19T01:14:14Z

Issue #, if available:

Description of changes:
These actions allow users to specify actions along with debugger rules during training. If the rule job finds issues during training, then the actions specified by the user will be triggered.

As of right now, support for actions is limited to debugger rules.

These changes include a dependency on smdebug-rulesconfig==1.0.1, which includes the action classes to be used as input to Rule.sagemaker via the actions parameters.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-12-19T01:16:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eaa56f5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T01:51:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eaa56f5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T01:55:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eaa56f5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T02:05:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: eaa56f5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T02:28:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b185d28
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T03:01:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b185d28
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T03:01:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b185d28
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-19T04:58:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b185d28
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable · 2020-12-21T20:54:40Z

src/sagemaker/debugger/debugger.py

+                """`actions` must be of type `Action` or `ActionList`!
+                """


Suggested change

"""`actions` must be of type `Action` or `ActionList`!

"""

"""`actions` must be of type `Action` or `ActionList`!"""

metrizable · 2020-12-21T20:54:57Z

src/sagemaker/debugger/debugger.py

+                """`actions` must be of type `Action` or `ActionList`!
+                """


Suggested change

"""`actions` must be of type `Action` or `ActionList`!

"""

"""`actions` must be of type `Action` or `ActionList`!"""

setup.py

sagemaker-bot · 2020-12-21T21:06:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 899c3f4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T21:12:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 82cf222
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T21:34:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 899c3f4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T21:37:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 899c3f4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T21:45:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 82cf222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T21:49:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 82cf222
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T22:03:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: beed15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T22:34:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: beed15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-21T22:37:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: beed15a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T01:20:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 12570a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T01:37:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 12570a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

looks good! can you add an integ test for the new actions support?

sagemaker-bot · 2020-12-22T19:24:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1f88c27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…dk into actions

sagemaker-bot · 2020-12-22T19:57:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f88c27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T19:57:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1f88c27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T20:03:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9576ac4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T20:35:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9576ac4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T20:38:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9576ac4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T20:45:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c0346ac
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T21:23:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c0346ac
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T21:25:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c0346ac
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T21:32:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c0346ac
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T21:33:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c0346ac
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…dk into actions

sagemaker-bot · 2020-12-22T21:41:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9cd4e69
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T22:18:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9cd4e69
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T22:21:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9cd4e69
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-22T23:31:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9db9f16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-23T00:02:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9db9f16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-23T00:05:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9db9f16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-12-23T00:06:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9db9f16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

looks good! thanks for the contribution!

ndodda-amazon added 5 commits December 16, 2020 13:04

Allow user to specify actions in debugger rules

dd7e28c

pin smdebug rules config

096de11

update validate function

1914cac

new line

3807439

fix merge conflict

eaa56f5

ndodda-amazon changed the title ~~feature: Add support for actions in debugger rules.~~ feat: Add support for actions in debugger rules. Dec 19, 2020

default actions to None in constructor

b185d28

metrizable approved these changes Dec 21, 2020

View reviewed changes

metrizable suggested changes Dec 21, 2020

View reviewed changes

Merge branch 'master' into actions

899c3f4

NihalHarish reviewed Dec 21, 2020

View reviewed changes

setup.py Show resolved Hide resolved

address comments

82cf222

fix reformatting error

beed15a

Merge branch 'master' into actions

1f88c27

metrizable reviewed Dec 22, 2020

View reviewed changes

ndodda-amazon added 2 commits December 22, 2020 11:54

add sanity integ tests

54e1455

Merge branch 'actions' of github.com:ndodda-amazon/sagemaker-python-s…

9576ac4

…dk into actions

Merge branch 'master' into actions

c0346ac

ndodda-amazon added 2 commits December 22, 2020 13:38

update helper function

2c7fc1c

Merge branch 'actions' of github.com:ndodda-amazon/sagemaker-python-s…

9cd4e69

…dk into actions

Merge branch 'master' into actions

9db9f16

metrizable approved these changes Dec 23, 2020

View reviewed changes

metrizable merged commit 39c6d5a into aws:master Dec 23, 2020

	"""`actions` must be of type `Action` or `ActionList`!
	"""
	"""`actions` must be of type `Action` or `ActionList`!"""

feat: Add support for actions in debugger rules. #2047

feat: Add support for actions in debugger rules. #2047

Uh oh!

Conversation

ndodda-amazon commented Dec 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 19, 2020

AWS CodeBuild CI Report

Uh oh!

metrizable Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

ndodda-amazon Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

metrizable Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

ndodda-amazon Dec 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 21, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 22, 2020

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 22, 2020

AWS CodeBuild CI Report

Uh oh!

ndodda-amazon commented Dec 19, 2020 •

edited

Loading