Skip to content

fix: Change Estimator.logs() to use latest_training_job.name #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 3, 2021
Merged

fix: Change Estimator.logs() to use latest_training_job.name #2059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f8e68a
Fix: Estimator.logs()
philschmid Dec 27, 2020
45374f6
Merge branch 'master' into patch-1
ahsan-z-khan Dec 28, 2020
9e2af27
Merge branch 'master' into patch-1
ahsan-z-khan Dec 30, 2020
582e22e
Merge branch 'master' into patch-1
ahsan-z-khan Jan 5, 2021
43bbd84
Merge branch 'master' into patch-1
ahsan-z-khan Jan 5, 2021
4434f0a
Merge branch 'master' into patch-1
Mar 2, 2021
4e5909b
update unit test to use name from training job
ChoiByungWook Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sagemaker/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ def logs(self):
If the output is a tty or a Jupyter cell, it will be color-coded based
on which instance the log entry is from.
"""
self.sagemaker_session.logs_for_job(self.latest_training_job, wait=True)
self.sagemaker_session.logs_for_job(self.latest_training_job.name, wait=True)

def deploy(
self,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,7 @@ def test_attach_no_logs(sagemaker_session, training_job_description):
def test_logs(sagemaker_session, training_job_description):
estimator = Estimator.attach(training_job_name="job", sagemaker_session=sagemaker_session)
estimator.logs()
sagemaker_session.logs_for_job.assert_called_with(estimator.latest_training_job, wait=True)
sagemaker_session.logs_for_job.assert_called_with(estimator.latest_training_job.name, wait=True)


def test_attach_without_hyperparameters(sagemaker_session, training_job_description):
Expand Down