Skip to content

fix: add service inserted fields to generated Hive DDL #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021
Merged

fix: add service inserted fields to generated Hive DDL #2074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebb29f
fix: add service inserted fields to generated Hive DDL
Jan 6, 2021
a4d4c22
Merge branch 'master' into fix-ddl
icywang86rui Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sagemaker/feature_store/feature_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,9 @@ def as_hive_ddl(self, database: str = "sagemaker_featurestore", table_name: str
f" {definition.feature_name} "
f"{self._FEATURE_TYPE_TO_DDL_DATA_TYPE_MAP.get(definition.feature_type.value)}\n"
)
ddl += " write_time TIMESTAMP\n"
ddl += " event_time TIMESTAMP\n"
ddl += " is_deleted BOOLEAN\n"
ddl += ")\n"
ddl += (
"ROW FORMAT SERDE 'org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe'\n"
Expand Down
6 changes: 5 additions & 1 deletion tests/integ/test_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ def create_table_ddl():
"CREATE EXTERNAL TABLE IF NOT EXISTS sagemaker_featurestore.{feature_group_name} (\n"
" feature1 FLOAT\n"
" feature2 INT\n"
" feature3 STRING\n)\n"
" feature3 STRING\n"
" write_time TIMESTAMP\n"
" event_time TIMESTAMP\n"
" is_deleted BOOLEAN\n"
")\n"
"ROW FORMAT SERDE 'org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe'\n"
" STORED AS\n"
" INPUTFORMAT 'parquet.hive.DeprecatedParquetInputFormat'\n"
Expand Down
6 changes: 5 additions & 1 deletion tests/unit/sagemaker/feature_store/test_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ def create_table_ddl():
"CREATE EXTERNAL TABLE IF NOT EXISTS {database}.{table_name} (\n"
" feature1 FLOAT\n"
" feature2 INT\n"
" feature3 STRING\n)\n"
" feature3 STRING\n"
" write_time TIMESTAMP\n"
" event_time TIMESTAMP\n"
" is_deleted BOOLEAN\n"
")\n"
"ROW FORMAT SERDE 'org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe'\n"
" STORED AS\n"
" INPUTFORMAT 'parquet.hive.DeprecatedParquetInputFormat'\n"
Expand Down