feature: Map image name to image uri #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
LGTM! Thanks for doing this! |
NihalHarish
approved these changes
Jan 21, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ahsan-z-khan
approved these changes
Jan 22, 2021
metrizable
pushed a commit
to metrizable/sagemaker-python-sdk
that referenced
this pull request
Jan 22, 2021
* Map image name to image uri * fix bug in test
ahsan-z-khan
pushed a commit
that referenced
this pull request
Jan 22, 2021
* feature: add support for Std:Join for pipelines * Update src/sagemaker/workflow/functions.py * Update tests/unit/sagemaker/workflow/test_functions.py * fix: ensure region is specified for workflow client * feature: Map image name to image uri (#2100) * Map image name to image uri * fix bug in test Co-authored-by: Neelesh Dodda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In sagemaker v2,
image_namewas renamed toimage_uri, which causes breaking changes for any customers still usingimage_namein their framework estimator. This PR resolves that issue by mappingimage_nametoimage_uriautomatically.Testing done:
Added a unit test that checks that specifying
image_namewill set theimage_uriattribute of the estimator correctly.Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.