Skip to content

fix: disable profiler by default for regions not support it #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 27, 2021
Merged

fix: disable profiler by default for regions not support it #2134

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb52ef5
fix: disable profiler by default for regions not support it
guoren66 Feb 11, 2021
b3846a9
Merge branch 'master' into fix-disable-profiler-settings
guoren66 Feb 11, 2021
7a91c3f
Merge branch 'master' into fix-disable-profiler-settings
metrizable Feb 16, 2021
3989034
Merge branch 'master' into fix-disable-profiler-settings
Feb 24, 2021
6e884b4
Merge branch 'master' into fix-disable-profiler-settings
Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sagemaker/estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,9 @@ def __init__(
self.profiler_config = profiler_config
self.disable_profiler = disable_profiler

if not _region_supports_profiler(self.sagemaker_session.boto_region_name):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think a test exercising this branch is warranted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been passed in Unit and integ test (mxnet using default profiler confit in test profiler) from my side. Do you think it's necessary to test the branch in environment of China regions?

self.disable_profiler = True

self.profiler_rule_configs = None
self.profiler_rules = None
self.debugger_rules = None
Expand Down