Add 30s cap time for tag tests #2141

stisac · 2021-02-12T19:41:38Z

Issue #, if available: https://sim.amazon.com/issues/AML-109456

Description of changes: Limit the max runtime for tag tests to 30s

Testing done:

tests/integ/sagemaker/lineage/test_action.py ....... [ 23%]
tests/integ/sagemaker/lineage/test_artifact.py ......... [ 53%]
tests/integ/sagemaker/lineage/test_association.py .... [ 66%]
tests/integ/sagemaker/lineage/test_context.py ....... [ 90%]
tests/integ/sagemaker/lineage/test_dataset_artifact.py . [ 93%]
tests/integ/sagemaker/lineage/test_endpoint_context.py . [ 96%]
tests/integ/sagemaker/lineage/test_model_artifact.py . [100%]

sagemaker-bot · 2021-02-12T19:43:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2838a6d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T19:50:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2838a6d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T20:23:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2838a6d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T20:39:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 08a36b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T20:39:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 08a36b1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T20:55:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ce5f41e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T20:55:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ce5f41e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T21:13:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bf58f90
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T21:18:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 08a36b1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T21:20:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bf58f90
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T21:34:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ce5f41e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T21:53:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bf58f90
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T22:26:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1cb92b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T22:34:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1cb92b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T23:07:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1cb92b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T23:12:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 144ecd9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T23:40:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 144ecd9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-12T23:44:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 144ecd9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable · 2021-02-12T23:49:18Z

setup.py

        "pytest-xdist",
+        "pytest-timeout",


nit: alphabetize?

Suggested change

"pytest-xdist",

"pytest-timeout",

"pytest-timeout",

"pytest-xdist",

Yep, will alphabetize. Thank you

metrizable · 2021-02-12T23:51:19Z

tests/integ/sagemaker/lineage/test_action.py

@@ -90,12 +94,14 @@ def test_tag(action_obj, sagemaker_session):
        )["Tags"]
        if actual_tags:
            break
+        time.sleep(1)


probably can increase sleep? it's not going to save much time to check every 1s and by increasing to, say, 5s, you reduce call volumes (and potential throttling) by a factor 5.

Good point, will update. Thank you

sagemaker-bot · 2021-02-13T00:14:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 19c07d9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable

thanks for the contribution!

sagemaker-bot · 2021-02-15T19:40:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dfbf410
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T19:54:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dfbf410
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T21:47:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a72854c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T22:06:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a72854c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T22:21:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a72854c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T22:26:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a72854c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T23:12:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2646819
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T23:41:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2646819
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-15T23:45:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2646819
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T01:05:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2646819
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T20:02:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e47eb16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T20:35:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e47eb16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T20:35:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e47eb16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T21:49:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e47eb16
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T21:59:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d89c3dd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T22:06:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d89c3dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T22:39:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d89c3dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T22:42:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d89c3dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T23:20:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d89c3dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T23:31:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1a7e6e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T23:57:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1a7e6e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-16T23:59:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1a7e6e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-17T00:03:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1a7e6e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-02-17T00:54:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1a7e6e7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

stisac force-pushed the iss109456 branch from 2838a6d to 08a36b1 Compare February 12, 2021 20:37

stisac force-pushed the iss109456 branch from 08a36b1 to ce5f41e Compare February 12, 2021 20:53

stisac force-pushed the iss109456 branch from ce5f41e to bf58f90 Compare February 12, 2021 21:11

danabens previously approved these changes Feb 12, 2021

View reviewed changes

stisac dismissed danabens’s stale review via 1cb92b6 February 12, 2021 22:25

stisac force-pushed the iss109456 branch from bf58f90 to 1cb92b6 Compare February 12, 2021 22:25

stisac force-pushed the iss109456 branch from 1cb92b6 to 144ecd9 Compare February 12, 2021 23:03

metrizable reviewed Feb 12, 2021

View reviewed changes

Add 30s cap time for tag tests

19c07d9

stisac force-pushed the iss109456 branch from 144ecd9 to 19c07d9 Compare February 13, 2021 00:05

metrizable approved these changes Feb 13, 2021

View reviewed changes

Merge branch 'master' into iss109456

a72854c

Merge branch 'master' into iss109456

2646819

Merge branch 'master' into iss109456

e47eb16

Merge branch 'master' into iss109456

d89c3dd

Merge branch 'master' into iss109456

1a7e6e7

ahsan-z-khan merged commit e7ad54c into aws:master Feb 17, 2021

Add 30s cap time for tag tests #2141

Add 30s cap time for tag tests #2141

Uh oh!

Conversation

stisac commented Feb 12, 2021

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 12, 2021

AWS CodeBuild CI Report

Uh oh!

metrizable Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

stisac Feb 13, 2021

Choose a reason for hiding this comment

Uh oh!

metrizable Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

stisac Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 13, 2021

AWS CodeBuild CI Report

Uh oh!

metrizable left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 15, 2021

AWS CodeBuild CI Report