Skip to content

infra: remove canary_quick pytest mark from flaky/unnecessary tests #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

infra: remove canary_quick pytest mark from flaky/unnecessary tests #2162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f054bcb
infra: remove canary_quick pytest mark from flaky/unnecessary tests
ajaykarpur Feb 18, 2021
d34f6d1
remove another mark
ajaykarpur Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/integ/test_airflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,6 @@ def test_rcf_airflow_config_uploads_data_source_to_s3(sagemaker_session, cpu_ins
)


@pytest.mark.canary_quick
def test_chainer_airflow_config_uploads_data_source_to_s3(
sagemaker_local_session, cpu_instance_type, chainer_latest_version, chainer_latest_py_version
):
Expand Down Expand Up @@ -476,7 +475,6 @@ def test_mxnet_airflow_config_uploads_data_source_to_s3(
)


@pytest.mark.canary_quick
def test_sklearn_airflow_config_uploads_data_source_to_s3(
sagemaker_session,
cpu_instance_type,
Expand Down
1 change: 0 additions & 1 deletion tests/integ/test_chainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ def test_training_with_additional_hyperparameters(
chainer.fit({"train": train_input, "test": test_input})


@pytest.mark.canary_quick
def test_attach_deploy(
sagemaker_session, chainer_latest_version, chainer_latest_py_version, cpu_instance_type
):
Expand Down
1 change: 0 additions & 1 deletion tests/integ/test_debugger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,6 @@ def test_mxnet_with_tensorboard_output_config(
_wait_and_assert_that_no_rule_jobs_errored(training_job=mx.latest_training_job)


@pytest.mark.canary_quick
def test_mxnet_with_all_rules_and_configs(
sagemaker_session,
mxnet_training_latest_version,
Expand Down
1 change: 0 additions & 1 deletion tests/integ/test_mxnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ def test_deploy_model_and_update_endpoint(
assert new_config["ProductionVariants"][0]["InitialInstanceCount"] == 1


@pytest.mark.canary_quick
@pytest.mark.skipif(
tests.integ.test_region() not in tests.integ.EI_SUPPORTED_REGIONS,
reason="EI isn't supported in that specific region.",
Expand Down