change: Do lazy initialization in predictor #2206

pinaraws · 2021-03-12T00:32:30Z

Do lazy initialization of model names and endpoint configuration name in predictor

Issue #, if available:

Description of changes:
When a predictor object is created, the initialization issues DescribeEndpoint and DescribeEndpointConfiguration API calls to get the model names and endpoint configuration name. These fields are only necessary for updating the predictor. They are unnecessary if we only want to make predict calls on the predictor object. The changes move the initialization to the relevant update functions to call the describe APIs if the fields have not been populated yet. This helps make the predictor object become more scalable by reducing the required API calls when only making predict requests.

Testing done:
The changes are covered by existing unit tests in test_predictor.py. All unit tests and integration tests still pass with the changes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ion name in predictor

ChoiByungWook

Do we need to update tests?

Requesting unit test updates

pinaraws · 2021-03-12T02:15:11Z

Do we need to update tests?

The existing unit tests already cover the functionality, I updated one test to reflect the new behavior.

sagemaker-bot · 2021-03-13T00:49:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c97926
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T18:35:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5c97926
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T18:51:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 36be8ec
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T19:07:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c97926
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T19:08:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5c97926
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T19:16:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5c97926
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T19:21:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c97926
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T20:27:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: be5c379
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T20:51:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: be5c379
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T20:55:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: be5c379
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T21:06:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: be5c379
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T21:13:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: be5c379
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-15T21:38:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: be5c379
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

integ test failing

ahsan-z-khan · 2021-03-15T22:06:51Z

Integ test is failing due to NoneType error

estimator = <sagemaker.mxnet.estimator.MXNet object at 0x7f12bb3e0a50>
instance_type = 'ml.m4.xlarge'
    def _deploy_estimator_and_assert_instance_type(estimator, instance_type):
        # don't use timeout_and_delete_endpoint_by_name because this tests if
        # deploy() creates a new endpoint config/endpoint each time
        with timeout(minutes=45):
            try:
                predictor = estimator.deploy(1, instance_type)
>               model_name = predictor._model_names[0]
E               TypeError: 'NoneType' object is not subscriptable
tests/integ/test_mxnet.py:100: TypeError

sagemaker-bot · 2021-03-16T07:13:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 47f913e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-16T07:39:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 47f913e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-16T07:45:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 47f913e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-16T07:47:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 47f913e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-16T07:47:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 47f913e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: Do lazy initialization of model names and endpoint configurat…

dd78d53

…ion name in predictor

ChoiByungWook previously approved these changes Mar 12, 2021

View reviewed changes

ChoiByungWook requested a review from ahsan-z-khan March 12, 2021 02:03

ChoiByungWook reviewed Mar 12, 2021

View reviewed changes

Update unit test for predictor

7d896a2

Update the predictor test with the correct assert

5c97926

ChoiByungWook previously approved these changes Mar 12, 2021

View reviewed changes

ahsan-z-khan previously approved these changes Mar 12, 2021

View reviewed changes

ChoiByungWook mentioned this pull request Mar 13, 2021

update pytorch_local_mode_cifar10.ipynb to 1.7.1 aws/amazon-sagemaker-examples#2078

Merged

fix: format to pass black-check and pylint

36be8ec

ahsan-z-khan dismissed stale reviews from ChoiByungWook and themself via 36be8ec March 15, 2021 18:47

Dan and others added 2 commits March 15, 2021 12:41

Merge branch 'master' into lazy-init

3b1df31

fix: format to pass black-check

be5c379

ahsan-z-khan previously approved these changes Mar 15, 2021

View reviewed changes

Update integ test to get the model name with method

47f913e

ahsan-z-khan approved these changes Mar 16, 2021

View reviewed changes

ahsan-z-khan merged commit dacacb6 into aws:master Mar 16, 2021

This was referenced Mar 18, 2021

Bump sagemaker from 1.56.1 to 2.30.0 in /components/aws/sagemaker/tests/unit_tests davidspek/kfp-tekton-backend#374

Closed

chore(deps): bump sagemaker from 2.1.0 to 2.30.0 in /components/aws/sagemaker davidspek/kfp-tekton#304

Closed

change: Do lazy initialization in predictor #2206

change: Do lazy initialization in predictor #2206

Uh oh!

Conversation

pinaraws commented Mar 12, 2021

Merge Checklist

General

Tests

Uh oh!

ChoiByungWook left a comment

Choose a reason for hiding this comment

Uh oh!

pinaraws commented Mar 12, 2021

Uh oh!

sagemaker-bot commented Mar 13, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 15, 2021

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan commented Mar 15, 2021

Uh oh!

sagemaker-bot commented Mar 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2021

AWS CodeBuild CI Report

Uh oh!

Uh oh!