Skip to content

fix: disable profiler in some release tests #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix: disable profiler in some release tests #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integ/test_horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def _create_and_fit_estimator(sagemaker_session, tf_version, py_version, instanc
py_version=py_version,
framework_version=tf_version,
distribution={"mpi": {"enabled": True}},
disable_profiler=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three tests often fail in a few small regions with InternalServiceErrors in our release pipeline. Service log showed in one instance the error happened when the training job trying to upload profiler data to s3. We are trying to see if this will fix our tests while the service team tries to root cause the issue.

)

with timeout.timeout(minutes=integ.TRAINING_DEFAULT_TIMEOUT_MINUTES):
Expand Down
1 change: 1 addition & 0 deletions tests/integ/test_huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def test_huggingface_training(
"repo": "https://github.com/huggingface/transformers.git",
"branch": f"v{huggingface_training_latest_version}",
},
disable_profiler=True,
)

train_input = hf.sagemaker_session.upload_data(
Expand Down
1 change: 1 addition & 0 deletions tests/integ/test_tf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ def test_mnist_distributed(
framework_version=tensorflow_training_latest_version,
py_version=tensorflow_training_latest_py_version,
distribution=PARAMETER_SERVER_DISTRIBUTION,
disable_profiler=True,
)
inputs = estimator.sagemaker_session.upload_data(
path=os.path.join(MNIST_RESOURCE_PATH, "data"), key_prefix="scriptmode/distributed_mnist"
Expand Down