Skip to content

Allow code_location to have no key prefix #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Allow code_location to have no key prefix #227

merged 3 commits into from
Jun 13, 2018

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Jun 12, 2018

Optionally, enable matching the behaviour when using sagemaker's default bucket where a key prefix is not permitted

Issue #, if available: 226

Description of changes: Addressing item 2.a on the issue

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ x] I have updated the changelog with a description of my changes (if appropriate)
  • [ x] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

humanzz added 2 commits June 12, 2018 13:35
Optionally, enable matching the behaviour when using sagemaker's default bucket where a key prefix is not permitted
@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #227 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files          45       45           
  Lines        3165     3165           
=======================================
  Hits         2895     2895           
  Misses        270      270
Impacted Files Coverage Δ
src/sagemaker/estimator.py 85.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3008a29...64f0854. Read the comment docs.

@jesterhazy
Copy link
Contributor

Thanks for the contribution!

@jesterhazy jesterhazy merged commit e9ed907 into aws:master Jun 13, 2018
@humanzz humanzz deleted the custom-bucket branch June 14, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants