Skip to content

Set TensorFlow default version to 1.8 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2018
Merged

Conversation

winstonaws
Copy link
Contributor

@winstonaws winstonaws commented Jun 20, 2018

Also includes:

  • updating tests to cover 1.7 and 1.8
  • updating Readme to include 1.7 and 1.8
  • updating Readme so that future version updates are easier / it won't fall out of sync with reality

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@winstonaws winstonaws requested a review from nadiaya June 20, 2018 16:03
@winstonaws winstonaws merged commit b8f00ff into aws:master Jun 20, 2018
@winstonaws winstonaws deleted the tf-1.7-1.8 branch June 20, 2018 20:31
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Nov 26, 2019
* Rename FileInput and FileOutput to ProcessingInput and ProcessingOutput

* Remove processing_ prefix from constructor parameter names

* Rename source to code in ScriptModeProcessor

* Mark CODE_CONTAINER_BASE_PATH and CODE_CONTAINER_INPUT_NAME as private

* Import NetworkConfig in processor module to aid with importing

* Rename processor module to processing

* Validate whether wait=False and run=True in Processor.run

* Remove attach method

* Modify Processor.run to only accept ProcessingOutputs for outputs

* Include input or output in generated S3 uris and change _CODE_CONTAINER values

* Update integ/test_processing::test_sklearn

* Fix docstring and call to wait/logs_for_processing_job

* Fix call to stop_processing_job
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
* Rename FileInput and FileOutput to ProcessingInput and ProcessingOutput

* Remove processing_ prefix from constructor parameter names

* Rename source to code in ScriptModeProcessor

* Mark CODE_CONTAINER_BASE_PATH and CODE_CONTAINER_INPUT_NAME as private

* Import NetworkConfig in processor module to aid with importing

* Rename processor module to processing

* Validate whether wait=False and run=True in Processor.run

* Remove attach method

* Modify Processor.run to only accept ProcessingOutputs for outputs

* Include input or output in generated S3 uris and change _CODE_CONTAINER values

* Update integ/test_processing::test_sklearn

* Fix docstring and call to wait/logs_for_processing_job

* Fix call to stop_processing_job
knakad pushed a commit that referenced this pull request Dec 4, 2019
* Rename FileInput and FileOutput to ProcessingInput and ProcessingOutput

* Remove processing_ prefix from constructor parameter names

* Rename source to code in ScriptModeProcessor

* Mark CODE_CONTAINER_BASE_PATH and CODE_CONTAINER_INPUT_NAME as private

* Import NetworkConfig in processor module to aid with importing

* Rename processor module to processing

* Validate whether wait=False and run=True in Processor.run

* Remove attach method

* Modify Processor.run to only accept ProcessingOutputs for outputs

* Include input or output in generated S3 uris and change _CODE_CONTAINER values

* Update integ/test_processing::test_sklearn

* Fix docstring and call to wait/logs_for_processing_job

* Fix call to stop_processing_job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants