Skip to content

fix: parameterize PT and TF version for HuggingFace tests #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 31 additions & 28 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,36 +190,9 @@ def pytorch_inference_py_version(pytorch_inference_version, request):
return "py3"


def _huggingface_base_fm_version(huggingface_vesion, base_fw):
config = image_uris.config_for_framework("huggingface")
training_config = config.get("training")
original_version = huggingface_vesion
if "version_aliases" in training_config:
huggingface_vesion = training_config.get("version_aliases").get(
huggingface_vesion, huggingface_vesion
)
version_config = training_config.get("versions").get(huggingface_vesion)
for key in list(version_config.keys()):
if key.startswith(base_fw):
base_fw_version = key[len(base_fw) :]
if len(original_version.split(".")) == 2:
base_fw_version = ".".join(base_fw_version.split(".")[:-1])
return base_fw_version


@pytest.fixture(scope="module")
def huggingface_pytorch_version(huggingface_training_version):
return _huggingface_base_fm_version(huggingface_training_version, "pytorch")


@pytest.fixture(scope="module")
def huggingface_pytorch_latest_version(huggingface_training_latest_version):
return _huggingface_base_fm_version(huggingface_training_latest_version, "pytorch")


@pytest.fixture(scope="module")
def huggingface_tensorflow_latest_version(huggingface_training_latest_version):
return _huggingface_base_fm_version(huggingface_training_latest_version, "tensorflow")
return _huggingface_base_fm_version(huggingface_training_version, "pytorch")[0]


@pytest.fixture(scope="module")
Expand Down Expand Up @@ -395,6 +368,32 @@ def _generate_all_framework_version_fixtures(metafunc):
)


def _huggingface_base_fm_version(huggingface_vesion, base_fw):
config = image_uris.config_for_framework("huggingface")
training_config = config.get("training")
original_version = huggingface_vesion
if "version_aliases" in training_config:
huggingface_vesion = training_config.get("version_aliases").get(
huggingface_vesion, huggingface_vesion
)
version_config = training_config.get("versions").get(huggingface_vesion)
versions = list()
for key in list(version_config.keys()):
if key.startswith(base_fw):
base_fw_version = key[len(base_fw) :]
if len(original_version.split(".")) == 2:
base_fw_version = ".".join(base_fw_version.split(".")[:-1])
versions.append(base_fw_version)
return versions


def _generate_huggingface_base_fw_latest_versions(metafunc, huggingface_version, base_fw):
versions = _huggingface_base_fm_version(huggingface_version, base_fw)
fixture_name = f"huggingface_{base_fw}_latest_version"
if fixture_name in metafunc.fixturenames:
metafunc.parametrize(fixture_name, versions, scope="session")


def _parametrize_framework_version_fixtures(metafunc, fixture_prefix, config):
fixture_name = "{}_version".format(fixture_prefix)
if fixture_name in metafunc.fixturenames:
Expand All @@ -407,6 +406,10 @@ def _parametrize_framework_version_fixtures(metafunc, fixture_prefix, config):
if fixture_name in metafunc.fixturenames:
metafunc.parametrize(fixture_name, (latest_version,), scope="session")

if "huggingface" in fixture_prefix:
_generate_huggingface_base_fw_latest_versions(metafunc, latest_version, "pytorch")
_generate_huggingface_base_fw_latest_versions(metafunc, latest_version, "tensorflow")

fixture_name = "{}_latest_py_version".format(fixture_prefix)
if fixture_name in metafunc.fixturenames:
config = config["versions"]
Expand Down
Loading