Skip to content

Fix unit test stability with testing job name generation #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2018

Conversation

laurenyu
Copy link
Contributor

Since the job name generation depends on timestamps being unique, if the two names were generated quickly enough, the names could end up being the same despite the code's logic being correct. Adding a sleep statement in the test should fix this.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

laurenyu added 2 commits June 21, 2018 15:15
Since the job name generation depends on timestamps being unique,
if the two names were generated quickly enough, the names could end
up being the same despite the code's logic being correct. Adding a
sleep statement in the test should fix this.
@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          49       49           
  Lines        3259     3259           
=======================================
  Hits         3008     3008           
  Misses        251      251

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c4e20...ff96257. Read the comment docs.

@laurenyu laurenyu merged commit 54b6660 into aws:master Jun 22, 2018
@laurenyu laurenyu deleted the fix-unit-test branch June 22, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants