documentation: smddp 1.2.1 release note / convert md to rst #2493

mchoi8739 · 2021-06-29T05:15:08Z

Description of changes:
SageMaker distributed data parallel 1.2.1 release note with TF2.5.0 DLC release.

Testing done:

Completed running tox -e black-check,flake8,docstyle,sphinx,doc8 --parallel all locally.
Built the doc running make html locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-06-29T05:17:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: efdf189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T05:17:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: efdf189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T05:17:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: efdf189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T05:18:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: efdf189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T05:26:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: efdf189
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

yselivonchyk · 2021-06-29T19:11:34Z

doc/api/training/smd_data_parallel_release_notes/smd_data_parallel_change_log.rst

+
+-  Improved performance on a single node.
+-  Improved performance on small clusters (2-4 nodes).
+-  Improved performance of ``Accumulator``.


This line `Improved performance of ``Accumulator``` is too technical and duplicates 2-4 nodes perf improvements. We can remove it.

removed the line

sagemaker-bot · 2021-06-29T20:00:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4d69fcd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:00:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4d69fcd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:01:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4d69fcd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:01:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4d69fcd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:07:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bb82801
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:12:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b7b0c45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:35:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bb82801
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:35:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bb82801
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:37:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b7b0c45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:40:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bb82801
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:44:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b7b0c45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:44:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b7b0c45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rondogency · 2021-06-29T20:43:57Z

doc/api/training/smd_data_parallel_release_notes/smd_data_parallel_change_log.rst

+**Improvements**
+
+-  Improved performance on a single node.
+-  Improved performance on small clusters (2-4 nodes).


should we put them together - Improved performance on single node and small clusters (2-4 nodes).

incorporated

rondogency · 2021-06-29T20:44:29Z

doc/api/training/smd_data_parallel_release_notes/smd_data_parallel_change_log.rst

+
+  .. code::
+
+    763104351884.dkr.ecr.<region>.amazonaws.com/tensorflow-training:2.5.0-gpu-py37-cu112-ubuntu18.04-v1.0


you can remove that suffix v1.0

ok maybe we should have it, since tag 2.5.0-gpu-py37-cu112-ubuntu18.04 will govern all future 2.5 tag, and we may have smddp 1.3 goes into tf 2.5.0

For smddp 1.3.0, we will publish another release note.

rondogency · 2021-06-29T20:45:29Z

doc/api/training/smd_data_parallel_release_notes/smd_data_parallel_change_log.rst

+
+**Bug fixes**
+
+-  Device selection for SageMaker.


@yselivonchyk do we need to include it also? it is also very technical

I agree, we probably don't need to share that with the user

removing the list item

sagemaker-bot · 2021-06-29T21:14:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b7b0c45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:30:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 256bc01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:56:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 256bc01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:58:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 256bc01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:03:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 256bc01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:34:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 256bc01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:47:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 37d4468
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:47:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 37d4468
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:47:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 37d4468
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:48:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 37d4468
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T19:56:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 37d4468
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T21:26:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 593d59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T21:26:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 593d59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T21:27:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 593d59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T21:27:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 593d59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T21:35:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 593d59f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

apogupta2018

LGTM

mchoi8739 changed the title ~~smddp 1.2.1 release note / convert md to rst~~ [Documentation] smddp 1.2.1 release note / convert md to rst Jun 29, 2021

mchoi8739 added the type: documentation label Jun 29, 2021

mchoi8739 changed the title ~~[Documentation] smddp 1.2.1 release note / convert md to rst~~ documentation: smddp 1.2.1 release note / convert md to rst Jun 29, 2021

yselivonchyk reviewed Jun 29, 2021

View reviewed changes

mchoi8739 force-pushed the smddp-1.2.1-doc branch 2 times, most recently from 4d69fcd to bb82801 Compare June 29, 2021 19:57

mchoi8739 added 2 commits June 29, 2021 13:01

documentation: smddp 1.2.1 release note / convert md to rst

3040723

documentation: incorp feedback

b7b0c45

mchoi8739 force-pushed the smddp-1.2.1-doc branch from bb82801 to b7b0c45 Compare June 29, 2021 20:02

rondogency reviewed Jun 29, 2021

View reviewed changes

rondogency previously approved these changes Jun 30, 2021

View reviewed changes

incorp feedback

256bc01

mchoi8739 dismissed rondogency’s stale review via 256bc01 June 30, 2021 18:19

rondogency approved these changes Jun 30, 2021

View reviewed changes

yselivonchyk approved these changes Jun 30, 2021

View reviewed changes

Merge branch 'master' into smddp-1.2.1-doc

37d4468

Merge branch 'master' into smddp-1.2.1-doc

593d59f

apogupta2018 approved these changes Jun 30, 2021

View reviewed changes

apogupta2018 merged commit f4ad8b2 into aws:master Jun 30, 2021


		.. code::

		763104351884.dkr.ecr.<region>.amazonaws.com/tensorflow-training:2.5.0-gpu-py37-cu112-ubuntu18.04-v1.0

documentation: smddp 1.2.1 release note / convert md to rst #2493

documentation: smddp 1.2.1 release note / convert md to rst #2493

Uh oh!

Conversation

mchoi8739 commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mchoi8739 Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

mchoi8739 commented Jun 29, 2021 •

edited

Loading

mchoi8739 Jun 29, 2021 •

edited

Loading