Skip to content

fix: fixes sklearn integ tests, remove swallowing exception on feature group delete attempt #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2021
Merged

fix: fixes sklearn integ tests, remove swallowing exception on feature group delete attempt #2563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a2ccd85
Remove swallowing exception on feature group delete attempt
shreyapandit Aug 7, 2021
11cf040
fix black format issues and update test for sklearn
shreyapandit Aug 7, 2021
08a5c25
fix passing in python3 as command
shreyapandit Aug 7, 2021
fc2868b
fix passing in python3 as command for network config test
shreyapandit Aug 7, 2021
76e7760
remove asserts that no longer hold
shreyapandit Aug 9, 2021
336c7d2
Merge branch 'master' into raise_error_fg_delete
ahsan-z-khan Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/integ/test_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,4 +312,4 @@ def cleanup_feature_group(feature_group: FeatureGroup):
try:
feature_group.delete()
except Exception:
pass
raise RuntimeError(f"Failed to delete feature group with name {feature_group.name}")
3 changes: 2 additions & 1 deletion tests/integ/test_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def test_sklearn_with_customizations(
sklearn_processor = SKLearnProcessor(
framework_version=sklearn_latest_version,
role=ROLE,
command=["python3"],
instance_type=cpu_instance_type,
instance_count=1,
volume_size_in_gb=100,
Expand Down Expand Up @@ -287,7 +288,6 @@ def test_sklearn_with_custom_default_bucket(

assert job_description["ProcessingInputs"][0]["InputName"] == "dummy_input"
assert custom_bucket_name in job_description["ProcessingInputs"][0]["S3Input"]["S3Uri"]

assert job_description["ProcessingJobName"].startswith("test-sklearn-with-customizations")

assert job_description["ProcessingJobStatus"] == "Completed"
Expand Down Expand Up @@ -677,6 +677,7 @@ def test_sklearn_with_network_config(sagemaker_session, sklearn_latest_version,
sklearn_processor = SKLearnProcessor(
framework_version=sklearn_latest_version,
role=ROLE,
command=["python3"],
instance_type=cpu_instance_type,
instance_count=1,
sagemaker_session=sagemaker_session,
Expand Down