Skip to content

fix: pin docker to 5.0.0 #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Sep 1, 2021

Issue #, if available:

See docker/docker-py#2886. Getting the same issue using local mode.

Description of changes:
Docker is required by docker compose. Edit setup.py to not allow a 5.0.1 offending version of docker. Fails with the same issue mentioned in the linked PR. This will force in stall of a version without the issue, hopefully this issue will be patched in the next docker release, the docker pr is approved already.

Testing done:
Failed in ci and while developing. Doing this in my project resolved the issue. Would be good to get it in to sagemaker itself.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ X] I have read the CONTRIBUTING doc
  • [ X] I used the commit message format described in CONTRIBUTING
  • [ X] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ X] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ X] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ X] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ X] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 2185415
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5b57baa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan
ahsan-z-khan previously approved these changes Sep 1, 2021
shreyapandit
shreyapandit previously approved these changes Sep 1, 2021
navinsoni
navinsoni previously approved these changes Sep 1, 2021
@ahsan-z-khan ahsan-z-khan dismissed stale reviews from navinsoni, shreyapandit, and themself via fb018ca September 1, 2021 17:41
@ahsan-z-khan
Copy link
Member

@jmahlik , Thanks for contributing!

I'm pinning docker to 5.0.0 for now.

@shreyapandit shreyapandit changed the title fix: local mode do not allow docker-py 5.0.1 due to buffering issue fix: pin docker to 5.0.0 Sep 1, 2021
@shreyapandit shreyapandit merged commit bc05a58 into aws:master Sep 1, 2021
@jmahlik jmahlik deleted the remove-docker-5.0.1 branch September 1, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants