Documentation: instance_type no longer hidden in instance_count documentation #2615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r hidden in instance_count documentation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
navinsoni
reviewed
Sep 1, 2021
src/sagemaker/algorithm.py
Outdated
| @@ -72,8 +72,8 @@ def __init__( | |||
| is created, the inference code might use the IAM role, if it | |||
| needs to access an AWS resource. | |||
| instance_count (int): Number of Amazon EC2 instances to | |||
| use for training. instance_type (str): Type of EC2 | |||
| instance to use for training, for example, 'ml.c4.xlarge'. | |||
| use for training. | |||
There was a problem hiding this comment.
Can you please move this to above line.
There was a problem hiding this comment.
good point. done!
ahsan-z-khan
approved these changes
Sep 17, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
navinsoni
approved these changes
Sep 17, 2021
jerrypeng7773
pushed a commit
to jerrypeng7773/sagemaker-python-sdk
that referenced
this pull request
Sep 24, 2021
EthanShouhanCheng
pushed a commit
to SissiChenxy/sagemaker-python-sdk
that referenced
this pull request
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
no issue
Description of changes:
instance_typedocumentation was hidden within the docs ofinstance_count. Made it more obvious.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.