feature: Add support for TF 2.5 #2710

saimidu · 2021-10-16T06:51:58Z

Issue #, if available:

Description of changes:

Add support for TF 2.4.3, TF 2.5.0, TF 2.5.1, and TF 2.6
Modify the test fixtures generating python versions to use py38 for future TF versions

Testing done:
Ran unit tests locally to test all changes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-10-16T07:06:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dc8536c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-16T07:44:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dc8536c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-16T07:49:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dc8536c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

saimidu · 2021-10-16T08:05:21Z

There seems to be a failing test_mnist_async test for TF 2.6 due to a call being made internally to use a deprecated feature on the TF training job:

tensorflow.python.framework.errors_impl.UnimplementedError: File system scheme 's3' not implemented

at line

sagemaker-python-sdk/tests/data/tensorflow_mnist/mnist.py

Line 172 in c95c75a

tf.estimator.train_and_evaluate(mnist_classifier, train_spec, eval_spec)

which may be caused by the use of compat.v1 APIs.

Reference: https://giters.com/tensorflow/tensorflow/issues/51583?amp=1

sagemaker-bot · 2021-10-18T06:56:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 40ada5f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T07:34:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 40ada5f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T07:38:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 40ada5f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

@saimidu Are you going to add TF2.6 to this PR too?

sagemaker-bot · 2021-10-18T20:29:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8d7bd9a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T21:10:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8d7bd9a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T21:12:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8d7bd9a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T23:10:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 19efac2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-18T23:49:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 19efac2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-19T06:03:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9a91513
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-19T06:41:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9a91513
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-19T07:08:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9a91513
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-20T09:19:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cab3091
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-20T10:00:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cab3091
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-10-20T10:05:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cab3091
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feature: Add support for new TF versions * Correct TF py version fixtures * Fix formatting * Remove TF 2.6 Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Shreya Pandit <[email protected]>

saimidu added 3 commits October 15, 2021 23:17

feature: Add support for new TF versions

970eb4e

Correct TF py version fixtures

ffef02f

Fix formatting

dc8536c

Remove TF 2.6

40ada5f

saimidu changed the title ~~feature: Add support for new TF versions~~ feature: Add support for new TF 2.5 Oct 18, 2021

saimidu changed the title ~~feature: Add support for new TF 2.5~~ feature: Add support for TF 2.5 Oct 18, 2021

ahsan-z-khan changed the title ~~feature: Add support for TF 2.5~~ feature: Add support for TF 2.5 and TF 2.6 Oct 18, 2021

Merge branch 'master' into add_new_tensorflow_version

8d7bd9a

ahsan-z-khan changed the title ~~feature: Add support for TF 2.5 and TF 2.6~~ feature: Add support for TF 2.5 Oct 18, 2021

ahsan-z-khan reviewed Oct 18, 2021

View reviewed changes

Merge branch 'master' into add_new_tensorflow_version

19efac2

Merge branch 'master' into add_new_tensorflow_version

9a91513

shreyapandit requested a review from ahsan-z-khan October 19, 2021 12:16

mufaddal-rohawala approved these changes Oct 19, 2021

View reviewed changes

ahsan-z-khan approved these changes Oct 19, 2021

View reviewed changes

Merge branch 'master' into add_new_tensorflow_version

cab3091

ahsan-z-khan merged commit 4039935 into aws:master Oct 20, 2021

NeilJonkers mentioned this pull request Oct 29, 2021

When do we support tensorflow >= 2.5 training images in the sdk? #2648

Closed

feature: Add support for TF 2.5 #2710

feature: Add support for TF 2.5 #2710

Uh oh!

Conversation

saimidu commented Oct 16, 2021

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Oct 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 16, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 16, 2021

AWS CodeBuild CI Report

Uh oh!

saimidu commented Oct 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 19, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 19, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 19, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 20, 2021

AWS CodeBuild CI Report

Uh oh!

Uh oh!

saimidu commented Oct 16, 2021 •

edited

Loading