-
Notifications
You must be signed in to change notification settings - Fork 1.2k
documentation: Add Jumpstart support documentation #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: only non-blocking comments. Thanks @IvyBazan
model_data=base_model_uri, | ||
source_dir=script_uri, | ||
entry_point="inference.py", | ||
role=Session().get_caller_identity_arn(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future PR: All JumpStart models can be deployed in network isolation. How about passing the network isolation argument set to True
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't make reference to network isolation in the P0 docs but I agree that there should be some documentation for this in the future. I'd like to try a gameday with this flag on.
role=Session().get_caller_identity_arn(), | ||
hyperparameters=default_hyperparameters, | ||
instance_count=instance_count, | ||
instance_type=training_instance_type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future PR: same comment here on enabling network isolation for training.
entry_point="inference.py", | ||
image_uri=deploy_image_uri, | ||
source_dir=deploy_script_uri, | ||
endpoint_name=endpoint_name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future PR: same comment re network isolation.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## dev #2890 +/- ##
=======================================
Coverage 89.08% 89.08%
=======================================
Files 182 182
Lines 15945 15945
=======================================
Hits 14205 14205
Misses 1740 1740 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Co-authored-by: keerthanvasist <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>
Description of changes:
Added new documentation for Amazon JumpStart support
Testing done:
built locally
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.