deprecate: Remove deprecated argument s3_data_distribution_type #3064

keerthanvasist · 2022-04-12T22:49:38Z

Description of changes:
Remove deprecated argument s3_data_distribution_type. We have already given enough warning time for customers to stop using this parameter. Besides, the deprecation warning has removed the DataConfig parameter from the docs. In order to resolve that, and complete the deprecation, we are removing the parameter s3_data_distribution_type.

Testing done:
Unit tests passed.

Merge Checklist

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-04-12T23:06:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bb45474
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-04-12T23:07:21Z

Codecov Report

Merging #3064 (626430b) into master (57d4763) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
- Coverage   89.60%   89.52%   -0.08%     
==========================================
  Files        1043      199     -844     
  Lines       86746    17171   -69575     
==========================================
- Hits        77728    15373   -62355     
+ Misses       9018     1798    -7220

Impacted Files	Coverage Δ
src/sagemaker/clarify.py	`95.41% <ø> (-0.06%)`	⬇️
...b/python3.8/site-packages/sagemaker/mxnet/model.py
...es/sagemaker/cli/compatibility/v2/modifiers/tfs.py
...3.7/site-packages/sagemaker/wrangler/processing.py
....9/site-packages/sagemaker/huggingface/__init__.py
...b/python3.7/site-packages/sagemaker/local/image.py
.../sagemaker/cli/compatibility/v2/modifiers/serde.py
...n3.9/site-packages/sagemaker/lineage/visualizer.py
...hon3.9/site-packages/sagemaker/pytorch/defaults.py
...7/site-packages/sagemaker/environment_variables.py
... and 836 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d4763...626430b. Read the comment docs.

sagemaker-bot · 2022-04-12T23:17:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bb45474
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-19T00:14:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4eebd7b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

Unit tests are failing on formatting and flake8. Please run the tests locally before committing. Also consider having the pre-push hook mentioned in the guide.

sagemaker-bot · 2022-04-29T19:53:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bdef1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-29T20:08:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bdef1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-29T20:18:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bdef1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-29T20:19:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bdef1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-29T20:40:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bdef1a8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-03T17:26:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 626430b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-03T17:39:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 626430b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-03T17:55:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 626430b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-03T18:10:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 626430b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-03T18:22:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 626430b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…3064) Co-authored-by: Shreya Pandit <[email protected]>

keerthanvasist mentioned this pull request Apr 18, 2022

Add deprecation warning in Clarify DataConfig #2847

Merged

8 tasks

keerthanvasist force-pushed the dep branch from bb45474 to 4eebd7b Compare April 19, 2022 00:00

ahsan-z-khan suggested changes Apr 20, 2022

View reviewed changes

mufaddal-rohawala added the needs contributor changes label Apr 22, 2022

deprecate: Remove deprecated argument s3_data_distribution_type

bdef1a8

keerthanvasist force-pushed the dep branch from 4eebd7b to bdef1a8 Compare April 29, 2022 19:33

keerthanvasist requested a review from ahsan-z-khan April 29, 2022 20:51

mufaddal-rohawala approved these changes May 2, 2022

View reviewed changes

shreyapandit approved these changes May 3, 2022

View reviewed changes

Merge branch 'master' into dep

626430b

ahsan-z-khan approved these changes May 3, 2022

View reviewed changes

navinsoni approved these changes May 3, 2022

View reviewed changes

shreyapandit merged commit 1d151c2 into aws:master May 3, 2022

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022

deprecate: Remove deprecated argument s3_data_distribution_type (aws#…

8001ba7

…3064) Co-authored-by: Shreya Pandit <[email protected]>

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 15, 2022

deprecate: Remove deprecated argument s3_data_distribution_type (aws#…

a5e5a3c

…3064) Co-authored-by: Shreya Pandit <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deprecate: Remove deprecated argument s3_data_distribution_type #3064

deprecate: Remove deprecated argument s3_data_distribution_type #3064

Uh oh!

keerthanvasist commented Apr 12, 2022 •

edited

Loading

Uh oh!

sagemaker-bot commented Apr 12, 2022

Uh oh!

codecov-commenter commented Apr 12, 2022 •

edited

Loading

Uh oh!

sagemaker-bot commented Apr 12, 2022

Uh oh!

sagemaker-bot commented Apr 19, 2022

Uh oh!

ahsan-z-khan left a comment

Uh oh!

sagemaker-bot commented Apr 29, 2022

Uh oh!

sagemaker-bot commented Apr 29, 2022

Uh oh!

sagemaker-bot commented Apr 29, 2022

Uh oh!

sagemaker-bot commented Apr 29, 2022

Uh oh!

sagemaker-bot commented Apr 29, 2022

Uh oh!

sagemaker-bot commented May 3, 2022

Uh oh!

sagemaker-bot commented May 3, 2022

Uh oh!

sagemaker-bot commented May 3, 2022

Uh oh!

sagemaker-bot commented May 3, 2022

Uh oh!

sagemaker-bot commented May 3, 2022

Uh oh!

Uh oh!

deprecate: Remove deprecated argument s3_data_distribution_type #3064

deprecate: Remove deprecated argument s3_data_distribution_type #3064

Uh oh!

Conversation

keerthanvasist commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Apr 12, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Apr 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 19, 2022

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 29, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 3, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

keerthanvasist commented Apr 12, 2022 •

edited

Loading

codecov-commenter commented Apr 12, 2022 •

edited

Loading