feature: add 'Domain' property to RegisterModel step #3118

rahven14 · 2022-05-18T11:02:34Z

Issue #, if available:

Description of changes:

add 'Domain' property to RegisterModel step

Testing done:

unit
Command used: export IGNORE_COVERAGE=- ; tox -e py38 -- -s -vv tests/unit/test_session.py::test_create_model_package_from_containers_all_args ; unset IGNORE_COVERAGE

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-05-18T11:06:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 31f6257
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

MadhubalasriB · 2022-05-18T11:10:37Z

src/sagemaker/session.py

@@ -4309,6 +4318,7 @@ def get_create_model_package_request(
    drift_check_baselines=None,
    customer_metadata_properties=None,
    validation_specification=None,
+    domain=None


Missing domain description here

added the missing domain description

sagemaker-bot · 2022-05-18T11:37:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 31f6257
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T11:46:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 31f6257
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T12:06:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 31f6257
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T12:18:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 31f6257
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

staubhp · 2022-05-18T17:59:55Z

src/sagemaker/estimator.py

@@ -1311,6 +1312,8 @@ def register(
            drift_check_baselines (DriftCheckBaselines): DriftCheckBaselines object (default: None).
            customer_metadata_properties (dict[str, str]): A dictionary of key-value paired
                metadata properties (default: None).
+            domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",


Is this true? I thought it was arbitrary string

Yes, this is true. It has been verified from the CLI as well.

sagemaker-bot · 2022-05-18T19:21:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4ea8a27
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T19:27:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8667c42
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:01:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8667c42
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:01:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4ea8a27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:11:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8667c42
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:20:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4ea8a27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:21:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8667c42
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:25:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4ea8a27
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-18T20:42:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8667c42
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T00:43:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8667c42
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…lint, flake8 issue

qidewenwhen · 2022-05-19T16:21:48Z

Out of curiosity, is there any reason we don't add the Domain to the register method of models like HuggingFaceModel, SKLearnModel and PipelineModel?

sagemaker-bot · 2022-05-19T16:33:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 43ea7a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T16:41:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8b83b46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-05-19T16:41:54Z

Codecov Report

Merging #3118 (985da79) into master (255a339) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master    #3118   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files         200      200           
  Lines       17318    17323    +5     
=======================================
+ Hits        15523    15528    +5     
  Misses       1795     1795

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`91.46% <ø> (ø)`
src/sagemaker/huggingface/model.py	`79.10% <ø> (ø)`
src/sagemaker/model.py	`92.58% <ø> (ø)`
src/sagemaker/mxnet/model.py	`96.36% <ø> (ø)`
src/sagemaker/pytorch/model.py	`85.45% <ø> (ø)`
src/sagemaker/sklearn/model.py	`81.63% <ø> (ø)`
src/sagemaker/tensorflow/model.py	`95.00% <ø> (ø)`
src/sagemaker/workflow/step_collections.py	`97.95% <ø> (ø)`
src/sagemaker/session.py	`71.05% <75.00%> (+0.09%)`	⬆️
src/sagemaker/workflow/_utils.py	`96.12% <100.00%> (+0.03%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255a339...985da79. Read the comment docs.

sagemaker-bot · 2022-05-19T16:49:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8b83b46
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T16:56:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 43ea7a4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T21:36:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 654cac4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T23:45:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 654cac4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This reverts commit 654cac4, reversing changes made to 7952ca3.

sagemaker-bot · 2022-05-20T07:07:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ff5ec7f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:30:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ff5ec7f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:34:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8b83b46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:47:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e2b54ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:56:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8b83b46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:57:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ff5ec7f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T07:58:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e2b54ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T08:13:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e2b54ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T08:18:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8b83b46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T08:19:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e2b54ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T08:21:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8b83b46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T08:30:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e2b54ee
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T09:36:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ff5ec7f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-21T00:16:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e2b54ee
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-23T06:27:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 985da79
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-23T06:49:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 985da79
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-23T07:07:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 985da79
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-23T07:21:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 985da79
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-23T08:46:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 985da79
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-24T16:45:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 985da79
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

feature: adding 'Domain' property to RegisterModel step

5301b31

MadhubalasriB reviewed May 18, 2022

View reviewed changes

MadhubalasriB approved these changes May 18, 2022

View reviewed changes

change: Include 'domain' description

4ea8a27

staubhp reviewed May 18, 2022

View reviewed changes

staubhp approved these changes May 18, 2022

View reviewed changes

rahven14 force-pushed the feature/add-domain-to-registermodel-step branch from 31f6257 to 4ea8a27 Compare May 18, 2022 19:17

change: add missing comma next to 'Domain' property to fix failing py…

8b83b46

…lint, flake8 issue

rahven14 force-pushed the feature/add-domain-to-registermodel-step branch from 43ea7a4 to 8b83b46 Compare May 19, 2022 16:15

rahven14 added a commit to rahven14/sagemaker-python-sdk that referenced this pull request May 20, 2022

Revert "change: resolve merge conflicts for PR aws#3118"

ff5ec7f

This reverts commit 654cac4, reversing changes made to 7952ca3.

rahven14 force-pushed the feature/add-domain-to-registermodel-step branch from ff5ec7f to 8b83b46 Compare May 20, 2022 07:12

Merge branch 'aws:master' into feature/add-domain-to-registermodel-step

e2b54ee

shreyapandit approved these changes May 21, 2022

View reviewed changes

fix: fix missing 'domain' property for framework models

985da79

qidewenwhen approved these changes May 23, 2022

View reviewed changes

navinsoni approved these changes May 24, 2022

View reviewed changes

navinsoni merged commit 87937ad into aws:master May 24, 2022

feature: add 'Domain' property to RegisterModel step #3118

feature: add 'Domain' property to RegisterModel step #3118

Uh oh!

Conversation

rahven14 commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

MadhubalasriB May 18, 2022

Choose a reason for hiding this comment

Uh oh!

rahven14 May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

staubhp May 18, 2022

Choose a reason for hiding this comment

Uh oh!

rahven14 May 18, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 18, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 19, 2022

AWS CodeBuild CI Report

Uh oh!

qidewenwhen commented May 19, 2022

Uh oh!

sagemaker-bot commented May 19, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 19, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented May 19, 2022

rahven14 commented May 18, 2022 •

edited

Loading

codecov-commenter commented May 19, 2022 •

edited

Loading