change: Implement test mechanism for Pipeline variables #3163

qidewenwhen · 2022-06-07T19:46:19Z

Description of changes: Implement test mechanism for Pipeline variables to check if they are compatible with downstream classes

Testing done: N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-06-07T20:20:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: be86fae
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T20:23:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: be86fae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-06-07T20:34:16Z

Codecov Report

Merging #3163 (46bba68) into master (bbb715d) will decrease coverage by 0.58%.
The diff coverage is 97.10%.

@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
- Coverage   89.83%   89.25%   -0.59%     
==========================================
  Files         645      203     -442     
  Lines       55560    18383   -37177     
==========================================
- Hits        49913    16407   -33506     
+ Misses       5647     1976    -3671

Impacted Files	Coverage Δ
src/sagemaker/amazon/hyperparameter.py	`95.91% <ø> (ø)`
src/sagemaker/processing.py	`94.27% <ø> (ø)`
...agemaker/serverless/serverless_inference_config.py	`100.00% <ø> (ø)`
src/sagemaker/utils.py	`93.14% <ø> (ø)`
src/sagemaker/fw_utils.py	`90.80% <50.00%> (ø)`
src/sagemaker/sklearn/estimator.py	`96.87% <71.42%> (ø)`
src/sagemaker/tensorflow/estimator.py	`93.75% <75.00%> (ø)`
src/sagemaker/training_compiler/config.py	`82.22% <83.33%> (ø)`
src/sagemaker/estimator.py	`90.28% <85.71%> (ø)`
src/sagemaker/amazon/amazon_estimator.py	`88.07% <87.50%> (ø)`
... and 883 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

sagemaker-bot · 2022-06-07T20:34:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: be86fae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T21:00:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: be86fae
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-07T22:39:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: be86fae
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T02:20:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cf170d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T02:37:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cf170d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T02:37:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: cf170d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T02:52:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cf170d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T04:38:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cf170d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T20:04:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3aa6ebf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T20:06:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3aa6ebf
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T20:20:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3aa6ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T20:20:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3aa6ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-15T20:44:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3aa6ebf
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T19:42:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 10adb8a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T19:43:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 10adb8a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T20:21:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 10adb8a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T20:25:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 10adb8a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T20:49:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 10adb8a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…d estimators annotations for processors + estimators / test mechanism change remove debug print reformatting

annotations for processors + estimators / test mechanism change annotations for processors + estimators / test mechanism change remove debug print reformatting update TM and resolve all AIs and all untested subclasses Add ppl var annotation to all composite object for training Adjust tm for recent model changes

sagemaker-bot · 2022-08-05T03:02:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6c25b30
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-05T03:39:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 46bba68
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-05T04:17:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 46bba68
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-05T04:21:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 46bba68
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-05T04:37:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 46bba68
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-05T05:02:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 46bba68
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navaj0

update the name of the test folders

from

test_mechanism/
  test_code/
  test_entries/

to

test_pipeline_variable_compatibility/
  template/
  test_components/

navaj0 · 2022-08-05T19:09:24Z

...unit/sagemaker/workflow/test_mechanism/test_code/test_pipeline_var_compatibility_template.py

+                assert '{"Get": "Parameters.nw_cfg_subnets"}' in step_dsl
+                assert '{"Get": "Parameters.nw_cfg_security_group_ids"}' in step_dsl
+                assert '{"Get": "Parameters.nw_cfg_enable_nw_isolation"}' in step_dsl
+            if issubclass(self.clazz, SageMakerClarifyProcessor):


Is this even supported?

navaj0 · 2022-08-05T19:10:15Z

...unit/sagemaker/workflow/test_mechanism/test_code/test_pipeline_var_compatibility_template.py

+            ):
+                assert '{"Get": "Parameters.instance_group_name"}' in step_dsl
+                assert '{"Get": "Parameters.instance_group_instance_count"}' in step_dsl
+            if issubclass(self.clazz, AmazonAlgorithmEstimatorBase):


I'm OK if we skip those AmazonAlgorithmEstimators

mufaddal-rohawala · 2023-02-13T19:04:34Z

@qidewenwhen is this PR relevant, still in draft?

qidewenwhen · 2023-02-13T21:24:53Z

@qidewenwhen is this PR relevant, still in draft?

Hey @mufaddal-rohawala, the test mechanism introduced in this PR has been deprioritized. And some updates are required on top of this PR considering the Pipeline cache improvement we released in 10/2022. I'll close this PR at this point and reopen in the future if we resume the work.

qidewenwhen marked this pull request as draft June 7, 2022 19:46

qidewenwhen force-pushed the test_mech branch from be86fae to cf170d0 Compare June 15, 2022 01:47

qidewenwhen force-pushed the test_mech branch from cf170d0 to 3aa6ebf Compare June 15, 2022 19:32

qidewenwhen force-pushed the test_mech branch from 3aa6ebf to 10adb8a Compare June 22, 2022 19:37

qidewenwhen force-pushed the test_mech branch from 10adb8a to f9f02d3 Compare June 22, 2022 22:00

jerrypeng7773 and others added 4 commits August 2, 2022 16:03

change: Add PipelineVariable annotation for the rest of processors an…

3560d70

…d estimators annotations for processors + estimators / test mechanism change remove debug print reformatting

go with model base and tf

dcdf66f

go with estimator subclasses

bcb4e4c

qidewenwhen force-pushed the test_mech branch from 4dd85da to 6c25b30 Compare August 5, 2022 02:58

update TM as per latest estimator changes

46bba68

qidewenwhen force-pushed the test_mech branch from 6c25b30 to 46bba68 Compare August 5, 2022 03:33

navaj0 reviewed Aug 5, 2022

View reviewed changes

This was referenced Aug 24, 2022

change: Add PipelineVariable annotation for all processor subclasses #3328

Merged

change: Add PipelineVariable annotation to framework estimators #3329

Merged

qidewenwhen mentioned this pull request Sep 22, 2022

change: Add PipelineVariable annotation to Amazon estimators #3373

Merged

9 tasks

vikas0203 requested review from a team, navinsoni and knikure and removed request for a team November 23, 2022 21:32

vikas0203 assigned navinsoni Nov 23, 2022

trajanikant removed request for navinsoni and knikure February 8, 2023 19:56

trajanikant assigned mufaddal-rohawala and unassigned navinsoni Feb 8, 2023

trajanikant requested a review from mufaddal-rohawala February 8, 2023 19:57

qidewenwhen closed this Feb 13, 2023

change: Implement test mechanism for Pipeline variables #3163

change: Implement test mechanism for Pipeline variables #3163

Uh oh!

Conversation

qidewenwhen commented Jun 7, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 15, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 5, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 5, 2022

codecov-commenter commented Jun 7, 2022 •

edited

Loading