Skip to content

Fix default input channel name in mxnet README #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

icywang86rui
Copy link
Contributor

  • Change the default channel name from 'train' to 'training'

Issue #332, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Change the default channel name from 'train' to 'training'
@icywang86rui icywang86rui requested a review from yangaws August 2, 2018 22:27
Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #333 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   92.86%   93.03%   +0.16%     
==========================================
  Files          51       51              
  Lines        3560     3560              
==========================================
+ Hits         3306     3312       +6     
+ Misses        254      248       -6
Impacted Files Coverage Δ
src/sagemaker/local/image.py 88.85% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4021f9...86c468e. Read the comment docs.

@icywang86rui icywang86rui merged commit 394bb3c into aws:master Aug 2, 2018
jnclt pushed a commit to jnclt/sagemaker-python-sdk that referenced this pull request Aug 3, 2018
* Change the default channel name from 'train' to 'training'
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* Change the default channel name from 'train' to 'training'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants