Make record serializer accept one-dimensional arrays (#320) #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 93.03% 92.94% -0.09%
==========================================
Files 51 51
Lines 3560 3560
==========================================
- Hits 3312 3309 -3
- Misses 248 251 +3
Continue to review full report at Codecov.
|
2 tasks
icywang86rui
reviewed
Aug 3, 2018
CHANGELOG.rst
Outdated
| @@ -2,6 +2,10 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 1.8.1dev | |||
| ===== | |||
There was a problem hiding this comment.
Minor - Please add three more '='s.
yangaws
previously approved these changes
Aug 7, 2018
yangaws
approved these changes
Aug 7, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#320
Description of changes:
The record serializer processes reshaped arrays.
A unit test for the corresponding one-dimensional case added.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.