documentation: add a security note #3350

mchoi8739 · 2022-09-06T19:57:29Z

Description of changes:

Add a security note for hyperparameters

Testing done:

tox -e black-check,flake8,docstyle,sphinx,doc8,twine --parallel all

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-09-06T20:30:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2a06815
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-09-06T20:32:06Z

Codecov Report

Merging #3350 (6e1141a) into master (1fa2377) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6e1141a differs from pull request most recent head 425ecff. Consider uploading reports for the commit 425ecff to get more accurate results

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   89.17%   89.17%   -0.01%     
==========================================
  Files         204      204              
  Lines       18979    18977       -2     
==========================================
- Hits        16924    16922       -2     
  Misses       2055     2055

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`89.46% <ø> (-0.04%)`	⬇️
src/sagemaker/model.py	`93.12% <0.00%> (ø)`
src/sagemaker/inputs.py	`100.00% <0.00%> (ø)`
src/sagemaker/network.py	`100.00% <0.00%> (ø)`
src/sagemaker/pipeline.py	`85.33% <0.00%> (ø)`
src/sagemaker/processing.py	`94.33% <0.00%> (ø)`
src/sagemaker/mxnet/model.py	`98.41% <0.00%> (ø)`
src/sagemaker/chainer/model.py	`96.49% <0.00%> (ø)`
src/sagemaker/model_metrics.py	`100.00% <0.00%> (ø)`
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-09-06T20:34:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2a06815
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/estimator.py

sagemaker-bot · 2022-09-06T21:11:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 59eb6fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T21:26:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 59eb6fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T21:26:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 59eb6fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T22:01:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5c8548f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T22:10:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c8548f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T22:14:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5c8548f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T22:15:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5c8548f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-06T22:37:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c8548f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-08T00:32:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6e1141a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-08T00:36:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6e1141a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-08T00:51:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6e1141a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-08T01:09:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6e1141a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-08T02:55:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6e1141a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T22:56:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 425ecff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

asumitamazon · 2022-10-12T23:17:42Z

src/sagemaker/estimator.py

+                    You must not include any security-sensitive information, such as
+                    account access IDs, secrets, and tokens, in the dictionary for configuring
+                    hyperparameters. SageMaker rejects the training job request and returns an
+                    exception error for detected credentials, if such user input is found.


"exception error" -> "validation error" ?

Same for other places.

sagemaker-bot · 2022-10-12T23:41:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 425ecff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T23:47:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 425ecff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-12T23:59:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 425ecff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-13T01:45:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 425ecff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests, unit-tests

sagemaker-bot · 2022-12-05T17:19:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 425ecff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T18:18:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 425ecff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run unit-tests

sagemaker-bot · 2022-12-05T18:30:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 425ecff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run unit-tests

sagemaker-bot · 2022-12-05T19:21:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 425ecff
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-05T19:22:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 425ecff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mchoi8739 added 2 commits September 6, 2022 12:48

add a security note

12eabd3

fix to pass black-check and flake8

961fe77

mchoi8739 marked this pull request as ready for review September 6, 2022 19:57

fix typo

2a06815

mchoi8739 commented Sep 6, 2022

View reviewed changes

src/sagemaker/estimator.py Outdated Show resolved Hide resolved

src/sagemaker/estimator.py Outdated Show resolved Hide resolved

src/sagemaker/estimator.py Outdated Show resolved Hide resolved

mchoi8739 added 3 commits September 6, 2022 13:41

Update src/sagemaker/estimator.py

1c06fc8

Update src/sagemaker/estimator.py

3c39582

Update src/sagemaker/estimator.py

59eb6fb

mchoi8739 changed the title ~~add a security note~~ documentation: add a security note Sep 6, 2022

Merge branch 'master' into estimator-hyperparam-security-note

5c8548f

Merge branch 'master' into estimator-hyperparam-security-note

6e1141a

Merge branch 'master' into estimator-hyperparam-security-note

425ecff

asumitamazon reviewed Oct 12, 2022

View reviewed changes

vikas0203 requested review from a team, trajanikant and claytonparnell and removed request for a team November 23, 2022 21:29

vikas0203 assigned vikas0203 and trajanikant and unassigned vikas0203 Nov 23, 2022

trajanikant reviewed Dec 5, 2022

View reviewed changes

mufaddal-rohawala requested a review from a team as a code owner December 20, 2022 00:31

mchoi8739 mentioned this pull request Jan 31, 2023

documentation: add security note for the estimator hyperparameter arg #3622

Merged

9 tasks

mchoi8739 closed this Jan 31, 2023

mchoi8739 deleted the estimator-hyperparam-security-note branch January 31, 2023 09:10

documentation: add a security note #3350

documentation: add a security note #3350

Uh oh!

Conversation

mchoi8739 commented Sep 6, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

asumitamazon Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

asumitamazon Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 13, 2022

codecov-commenter commented Sep 6, 2022 •

edited

Loading

trajanikant left a comment •

edited

Loading