fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

knikure · 2022-10-06T23:05:01Z

The PR contains the fix for CreateModelPackage API failures for the Scikit-learn and XGBoost Frameworks. The issue is reported by the customer after the PR merged in the SageMaker repo.

Issue #, if available:

Description of changes:
Revert only changes for affected frameworks - Sklearn and XGBoost in this PR

Testing done:
No new tests introduced. Removed tests- test_register_sklearn_model_auto_infer_framework and test_register_xgboost_model_auto_infer_framework which are no longer required.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
[] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…orks

sagemaker-bot · 2022-10-06T23:09:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9676312
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-06T23:10:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9676312
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-06T23:48:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T00:13:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 539c01b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-10-07T00:14:38Z

Codecov Report

Merging #3400 (539c01b) into master (1fa2377) will decrease coverage by 0.19%.
The diff coverage is 82.72%.

@@            Coverage Diff             @@
##           master    #3400      +/-   ##
==========================================
- Coverage   89.17%   88.97%   -0.20%     
==========================================
  Files         204      205       +1     
  Lines       18979    19053      +74     
==========================================
+ Hits        16924    16952      +28     
- Misses       2055     2101      +46

Impacted Files	Coverage Δ
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
...sagemaker/workflow/monitor_batch_transform_step.py	`0.00% <0.00%> (ø)`
src/sagemaker/xgboost/model.py	`96.36% <ø> (-1.82%)`	⬇️
src/sagemaker/session.py	`71.41% <28.57%> (-0.25%)`	⬇️
src/sagemaker/estimator.py	`89.43% <71.42%> (-0.08%)`	⬇️
src/sagemaker/amazon/amazon_estimator.py	`87.82% <81.25%> (-0.62%)`	⬇️
src/sagemaker/amazon/lda.py	`98.03% <92.30%> (+0.16%)`	⬆️
src/sagemaker/amazon/factorization_machines.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ipinsights.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/kmeans.py	`100.00% <100.00%> (ø)`
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-10-07T00:32:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 539c01b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T00:39:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 539c01b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T00:45:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T02:37:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 539c01b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T02:52:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run slow-tests

sagemaker-bot · 2022-10-07T15:53:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-07T16:18:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-09T22:52:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-10T00:21:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 539c01b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…orkss (aws#3400)

fix: CreateModelPackage API error for Scikit-learn and XGBoost framew…

9676312

…orks

knikure requested review from rahven14 and removed request for rahven14 October 6, 2022 23:09

knikure requested a review from mufaddal-rohawala October 6, 2022 23:09

remove flake8 errors

539c01b

mufaddal-rohawala approved these changes Oct 6, 2022

View reviewed changes

knikure commented Oct 7, 2022

View reviewed changes

knikure changed the title ~~fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworks~~ fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss Oct 10, 2022

knikure merged commit e5ccfa7 into aws:master Oct 10, 2022

brockwade633 pushed a commit to brockwade633/sagemaker-python-sdk that referenced this pull request Oct 26, 2022

fix: CreateModelPackage API error for Scikit-learn and XGBoost framew…

f9097ca

…orkss (aws#3400)

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

fix: CreateModelPackage API error for Scikit-learn and XGBoost framew…

78c9a15

…orkss (aws#3400)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

Uh oh!

knikure commented Oct 6, 2022

Uh oh!

sagemaker-bot commented Oct 6, 2022

Uh oh!

sagemaker-bot commented Oct 6, 2022

Uh oh!

sagemaker-bot commented Oct 6, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

codecov-commenter commented Oct 7, 2022 •

edited

Loading

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

knikure left a comment •

edited

Loading

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 7, 2022

Uh oh!

sagemaker-bot commented Oct 9, 2022

Uh oh!

sagemaker-bot commented Oct 10, 2022

Uh oh!

Uh oh!

fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

fix: CreateModelPackage API error for Scikit-learn and XGBoost frameworkss #3400

Uh oh!

Conversation

knikure commented Oct 6, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Oct 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

knikure left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 9, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 10, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

codecov-commenter commented Oct 7, 2022 •

edited

Loading

knikure left a comment •

edited

Loading