change: Add new region support for MX, PT, TF on SM Training #3537

saimidu · 2022-12-14T01:31:36Z

Issue #, if available:

Description of changes:
Added "ap-south-2", "eu-central-2", "eu-south-2", and "ap-southeast-4" regions to MXNet, PyTorch, and TensorFlow Training images used by Estimators.

Testing done:
Ran unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-12-14T01:36:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e5a5ff8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T01:36:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e5a5ff8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T01:36:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e5a5ff8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-12-14T02:12:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e5a5ff8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-12-14T02:13:41Z

Codecov Report

Merging #3537 (1db4963) into master (1ad9d9c) will decrease coverage by 0.73%.
The diff coverage is 93.12%.

@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   89.75%   89.02%   -0.73%     
==========================================
  Files         968      230     -738     
  Lines       91168    22808   -68360     
==========================================
- Hits        81824    20304   -61520     
+ Misses       9344     2504    -6840

Impacted Files	Coverage Δ
src/sagemaker/djl_inference/model.py	`92.51% <92.51%> (ø)`
src/sagemaker/feature_store/dataset_builder.py	`87.87% <95.65%> (ø)`
src/sagemaker/djl_inference/__init__.py	`100.00% <100.00%> (ø)`
src/sagemaker/djl_inference/defaults.py	`100.00% <100.00%> (ø)`
...y39/lib/python3.9/site-packages/sagemaker/model.py
...8/lib/python3.8/site-packages/sagemaker/clarify.py
...b/python3.8/site-packages/sagemaker/local/image.py
...ite-packages/sagemaker/debugger/profiler_config.py
...on3.7/site-packages/sagemaker/workflow/__init__.py
...ib/python3.8/site-packages/sagemaker/exceptions.py
... and 1189 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-12-14T02:17:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e5a5ff8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-02-13T18:51:50Z

@saimidu can we rebase and resolve conflicts? is this PR in draft or ready to review?

sagemaker-bot · 2023-02-28T18:05:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cc5ce94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T18:05:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cc5ce94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T18:06:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cc5ce94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T18:41:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: cc5ce94
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-28T18:50:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cc5ce94
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T20:50:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1db4963
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T20:50:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1db4963
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T20:50:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1db4963
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T21:24:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1db4963
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T21:35:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1db4963
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run pr

sagemaker-bot · 2023-03-10T18:35:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1db4963
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

saimidu requested a review from a team as a code owner December 14, 2022 01:31

saimidu requested review from navinsoni and removed request for a team December 14, 2022 01:31

saimidu marked this pull request as draft December 15, 2022 21:09

kenny-ezirim approved these changes Dec 16, 2022

View reviewed changes

mufaddal-rohawala assigned navinsoni Dec 19, 2022

mufaddal-rohawala force-pushed the master branch from bae3b8b to d000bdc Compare December 20, 2022 00:31

trajanikant requested a review from mufaddal-rohawala February 8, 2023 20:03

trajanikant assigned mufaddal-rohawala and unassigned navinsoni Feb 8, 2023

trajanikant removed the request for review from navinsoni February 8, 2023 20:03

saimidu added 3 commits February 23, 2023 09:06

Add new region support for MX, PT, TF on SM Training

95f807f

Add pytorch-neuron.json

e5a7d2f

Add ap-southeast-4

105f23a

saimidu force-pushed the add_dlc_training_new_regions branch from e5a5ff8 to 105f23a Compare February 28, 2023 18:01

Merge branch 'master' into add_dlc_training_new_regions

cc5ce94

saimidu marked this pull request as ready for review February 28, 2023 18:02

mufaddal-rohawala approved these changes Mar 1, 2023

View reviewed changes

Merge branch 'master' into add_dlc_training_new_regions

1db4963

mufaddal-rohawala reviewed Mar 10, 2023

View reviewed changes

knikure merged commit ca22ac6 into aws:master Mar 13, 2023

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

change: Add new region support for MX, PT, TF on SM Training (aws#3537)

f8cdbc8

change: Add new region support for MX, PT, TF on SM Training #3537

change: Add new region support for MX, PT, TF on SM Training #3537

Uh oh!

Conversation

saimidu commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Dec 14, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 13, 2023

Uh oh!

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 6, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 10, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

saimidu commented Dec 14, 2022 •

edited

Loading

codecov-commenter commented Dec 14, 2022 •

edited

Loading