add p2 deprecation for PT>=1.13 #3567

ShiboXing · 2023-01-04T22:09:26Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-01-04T22:13:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f9c449a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ShiboXing · 2023-01-04T22:45:35Z

tested the code change effect with version 1.12 since PT-1.13 has not been released yet

sagemaker-bot · 2023-01-04T22:51:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f9c449a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-04T23:02:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f9c449a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-04T23:10:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f9c449a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-04T23:32:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f9c449a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T18:01:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 01d4401
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T18:08:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c55d16a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T18:52:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 562ded4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T18:53:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 562ded4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-06T18:55:19Z

Codecov Report

Merging #3567 (a0802b5) into master (a9b32ec) will decrease coverage by 0.79%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #3567      +/-   ##
==========================================
- Coverage   89.59%   88.80%   -0.80%     
==========================================
  Files         968      227     -741     
  Lines       89516    22141   -67375     
==========================================
- Hits        80204    19662   -60542     
+ Misses       9312     2479    -6833

Impacted Files	Coverage Δ
src/sagemaker/image_uris.py	`97.21% <80.00%> (ø)`
...0/site-packages/sagemaker/cli/framework_upgrade.py
...thon3.7/site-packages/sagemaker/apiutils/_utils.py
...agemaker/model_monitor/clarify_model_monitoring.py
.../site-packages/sagemaker/model_monitor/__init__.py
...ckages/sagemaker/model_monitor/model_monitoring.py
...8/lib/python3.8/site-packages/sagemaker/clarify.py
...ite-packages/sagemaker/async_inference/__init__.py
...3.10/site-packages/sagemaker/lineage/_api_types.py
...python3.8/site-packages/sagemaker/amazon/common.py
... and 1186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-06T19:14:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 562ded4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T19:36:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 562ded4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-06T19:39:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 562ded4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…eving pytorch img uri style: format _validate_instance_deprecation using black doc: add docstring for _validate_instance_deprecation doc: update deprecation error string doc: update docstring for _validate_instance_deprecation

sagemaker-bot · 2023-01-10T20:16:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 44d56b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T20:18:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 44d56b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T20:21:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 44d56b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T20:29:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 44d56b6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-10T20:36:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44d56b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T01:11:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44d56b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run notebook-tests

sagemaker-bot · 2023-01-11T02:11:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44d56b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T02:54:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 44d56b6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…into p2-deprecate

sagemaker-bot · 2023-01-11T03:34:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T04:08:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a0802b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T04:11:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a0802b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T04:20:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T04:22:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a0802b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests, notebook-tests

sagemaker-bot · 2023-01-11T17:22:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a0802b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T17:32:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run notebook-tests

sagemaker-bot · 2023-01-11T19:02:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run notebook-tests

sagemaker-bot · 2023-01-12T17:41:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run notebook-tests

sagemaker-bot · 2023-01-13T20:31:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-13T21:34:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-13T22:46:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-13T23:56:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T01:35:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T05:05:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a0802b5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feat: (squash and push to use git hooks) add p2 deprecation for retrieving pytorch img uri style: format _validate_instance_deprecation using black doc: add docstring for _validate_instance_deprecation doc: update deprecation error string doc: update docstring for _validate_instance_deprecation * fix: use Version packaging to compare version * test: add E1136 to pylintrc disable list Co-authored-by: Shibo Xing <[email protected]>

ShiboXing requested a review from a team as a code owner January 4, 2023 22:09

ShiboXing requested review from prateekmehrotra and removed request for a team January 4, 2023 22:09

claytonparnell requested review from claytonparnell and removed request for prateekmehrotra January 5, 2023 00:08

knikure assigned claytonparnell Jan 9, 2023

Shibo Xing added 3 commits January 10, 2023 17:39

fix: use Version packaging to compare version

de80f92

test: add E1136 to pylintrc disable list

44d56b6

ShiboXing force-pushed the p2-deprecate branch from 562ded4 to 44d56b6 Compare January 10, 2023 19:36

claytonparnell reviewed Jan 11, 2023

View reviewed changes

Merge branch 'master' of https://github.com/aws/sagemaker-python-sdk …

a0802b5

…into p2-deprecate

claytonparnell reviewed Jan 11, 2023

View reviewed changes

claytonparnell reviewed Jan 12, 2023

View reviewed changes

claytonparnell reviewed Jan 13, 2023

View reviewed changes

claytonparnell approved these changes Jan 14, 2023

View reviewed changes

claytonparnell merged commit 7faf9ce into aws:master Jan 14, 2023

add p2 deprecation for PT>=1.13 #3567

add p2 deprecation for PT>=1.13 #3567

Uh oh!

Conversation

ShiboXing commented Jan 4, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jan 4, 2023

AWS CodeBuild CI Report

Uh oh!

ShiboXing commented Jan 4, 2023

Uh oh!

sagemaker-bot commented Jan 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 4, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

claytonparnell left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jan 6, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading