Do not use print function. Use logger instead #3591

Guillem96 · 2023-01-16T12:02:53Z

Use logger instead of print function.
This allow developers using the library to silenc undesired output

Description of changes:

Remove print function and use logger.debug instead.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Use logger instead of print function. This allow developers using the library to silenc undesired output

Guillem96 · 2023-01-23T13:48:39Z

@navinsoni did you have the opportunity to take a look at this?

claytonparnell

/bot run slow-tests

sagemaker-bot · 2023-01-27T19:14:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6bf4752
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:16:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6bf4752
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:17:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6bf4752
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-27T19:37:22Z

Codecov Report

Merging #3591 (6bf4752) into master (483665a) will decrease coverage by 0.80%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3591      +/-   ##
==========================================
- Coverage   89.59%   88.80%   -0.80%     
==========================================
  Files         968      227     -741     
  Lines       89536    22140   -67396     
==========================================
- Hits        80219    19661   -60558     
+ Misses       9317     2479    -6838

Impacted Files	Coverage Δ
src/sagemaker/processing.py	`94.23% <100.00%> (ø)`
...n3.10/site-packages/sagemaker/pytorch/estimator.py
...gemaker/cli/compatibility/v2/modifiers/__init__.py
...te-packages/sagemaker/workflow/check_job_config.py
...packages/sagemaker/model_monitor/dataset_format.py
...hon3.7/site-packages/sagemaker/sklearn/__init__.py
...hon3.10/site-packages/sagemaker/jumpstart/cache.py
...ages/sagemaker/feature_store/feature_definition.py
...thon3.10/site-packages/sagemaker/spark/__init__.py
...te-packages/sagemaker/workflow/step_collections.py
... and 1186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-27T19:37:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6bf4752
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T19:38:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6bf4752
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell · 2023-01-27T19:39:27Z

Hi @Guillem96 - Navin is out of office for a bit but I am taking a look

sagemaker-bot · 2023-01-27T20:16:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6bf4752
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T20:43:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6bf4752
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T21:01:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6bf4752
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T22:22:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6bf4752
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Use logger instead of print function. This allow developers using the library to silenc undesired output

Do not use print function. User logger instead

36b7a27

Use logger instead of print function. This allow developers using the library to silenc undesired output

Guillem96 requested a review from a team as a code owner January 16, 2023 12:02

Guillem96 requested review from navinsoni and removed request for a team January 16, 2023 12:02

knikure assigned navinsoni Jan 17, 2023

Merge branch 'master' into patch-1

6bf4752

Guillem96 changed the title ~~Do not use print function. User logger instead~~ Do not use print function. Use logger instead Jan 19, 2023

claytonparnell reviewed Jan 27, 2023

View reviewed changes

claytonparnell self-assigned this Jan 27, 2023

claytonparnell approved these changes Jan 27, 2023

View reviewed changes

claytonparnell merged commit 76d9c5a into aws:master Jan 27, 2023

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

fix: Do not use print function. User logger instead (aws#3591)

9752a89

Use logger instead of print function. This allow developers using the library to silenc undesired output

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

fix: Do not use print function. User logger instead (aws#3591)

42547a1

Use logger instead of print function. This allow developers using the library to silenc undesired output

anjali-chadha mentioned this pull request Jun 16, 2023

Use logger and remove print statements #3938

Closed

martinRenou mentioned this pull request Sep 21, 2023

change Using logging instead of prints #4133

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not use print function. Use logger instead #3591

Do not use print function. Use logger instead #3591

Uh oh!

Guillem96 commented Jan 16, 2023

Uh oh!

Guillem96 commented Jan 23, 2023

Uh oh!

claytonparnell left a comment •

edited

Loading

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

codecov-commenter commented Jan 27, 2023 •

edited

Loading

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

claytonparnell commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

Uh oh!

Uh oh!

Do not use print function. Use logger instead #3591

Do not use print function. Use logger instead #3591

Uh oh!

Conversation

Guillem96 commented Jan 16, 2023

Merge Checklist

General

Tests

Uh oh!

Guillem96 commented Jan 23, 2023

Uh oh!

claytonparnell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

claytonparnell commented Jan 27, 2023

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 27, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

claytonparnell left a comment •

edited

Loading

codecov-commenter commented Jan 27, 2023 •

edited

Loading