Skip to content

feature: Support role as PipelineParameter in Processor class #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

feature: Support role as PipelineParameter in Processor class #3605

merged 1 commit into from
Jan 27, 2023

Conversation

francescoalongi
Copy link
Contributor

@francescoalongi francescoalongi commented Jan 20, 2023

Issue #, if available:
No issue associated

Description of changes:
Currently, the SDK throws an error if the role parameter of the Processor class is passed as PipelineParameter because it expects only strings. With this modification the class Processor is now able to accept the role parameter as PipelineParameter, enabling then the possibility of feeding the role parameter when the pipeline is triggered.

Testing done:

Merge Checklist

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@francescoalongi francescoalongi requested a review from a team as a code owner January 20, 2023 11:53
@francescoalongi francescoalongi requested review from knikure and removed request for a team January 20, 2023 11:53
@knikure knikure self-assigned this Jan 20, 2023
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f1764b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #3605 (f1764b6) into master (25c49d4) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   89.59%   88.80%   -0.79%     
==========================================
  Files         968      227     -741     
  Lines       89600    22157   -67443     
==========================================
- Hits        80279    19677   -60602     
+ Misses       9321     2480    -6841     
Impacted Files Coverage Δ
src/sagemaker/processing.py 94.25% <100.00%> (ø)
...3.7/site-packages/sagemaker/workflow/model_step.py
.../python3.10/site-packages/sagemaker/transformer.py
...hon3.10/site-packages/sagemaker/experiments/run.py
...b/python3.7/site-packages/sagemaker/transformer.py
...3.7/site-packages/sagemaker/tensorflow/__init__.py
...-packages/sagemaker/dataset_definition/__init__.py
...-packages/sagemaker/workflow/quality_check_step.py
...b/python3.7/site-packages/sagemaker/script_uris.py
...ference_recommender/inference_recommender_mixin.py
... and 1186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f1764b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: f1764b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: f1764b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f1764b6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure changed the title feature: support role as PipelineParameter in Processor class feature: Support role as PipelineParameter in Processor class Jan 27, 2023
@knikure knikure merged commit 75d1f2c into aws:master Jan 27, 2023
@petersaltin
Copy link

superb, ran into the issue with role not being supported as pipeline parameter for processor role yesterday so i am going to try this out!

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants