feature: Inference recommendation id deployment support #3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add IR id as input and validate compatible parameters * use inference_recommender_mixin * Add inf rec id support for deploy method * Invoke describe boto3 apis directly and wrap params update in mixin * Refactor mixin * Get compiled results from modelpkg * Fix describe calls * Add check for initial_instance_count * Fix flake8 and docstyle errors * Black reformat * Add recommendation id deployment support for estimator * Remove ir id for auto_ml model * Rebase on right size change Co-authored-by: Jinpeng Qi <[email protected]>
* Add integ test and refactor rec id deploy * Revert ir id hardcode change * Fix framework parse --------- Co-authored-by: Jinpeng Qi <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 89.56% 88.80% -0.77%
==========================================
Files 968 227 -741
Lines 89844 22278 -67566
==========================================
- Hits 80470 19784 -60686
+ Misses 9374 2494 -6880
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trajanikant
approved these changes
Feb 3, 2023
JoseJuan98
pushed a commit
to JoseJuan98/sagemaker-python-sdk
that referenced
this pull request
Mar 4, 2023
Co-authored-by: Jinpeng Qi <[email protected]>
nmadan
pushed a commit
to nmadan/sagemaker-python-sdk
that referenced
this pull request
Apr 18, 2023
Co-authored-by: Jinpeng Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.