[Feature - Hugging Face] Update Transformers 4.26 - PyTorch 1.13.1 Image uri #3670

JingyaHuang · 2023-02-20T17:22:16Z

Issue [Feature - Hugging Face] Add new DLCs(transformers 4.26.0) to Image config #3669

Description of changes:

Update Image URI for:

Transformers 4.26 - PyTorch 1.13.1 Training DLC: [huggingface_pytorch] PT1.13 Training - update for Transformers to 4.26.0 deep-learning-containers#2678
Transformers 4.26 - PyTorch 1.13.1 Inference DLC: [huggingface_pytorch] Inference - update for Transformers to 4.26.0 deep-learning-containers#2679

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

trajanikant

/bot run all

sagemaker-bot · 2023-02-21T20:17:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: eabd6b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T20:19:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eabd6b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-02-21T20:21:38Z

Codecov Report

Merging #3670 (972a60f) into master (1b4892a) will decrease coverage by 0.82%.
The diff coverage is n/a.

❗ Current head 972a60f differs from pull request most recent head 4d13345. Consider uploading reports for the commit 4d13345 to get more accurate results

@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
- Coverage   89.84%   89.02%   -0.82%     
==========================================
  Files         984      230     -754     
  Lines       92292    22808   -69484     
==========================================
- Hits        82916    20304   -62612     
+ Misses       9376     2504    -6872

see 1214 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-02-21T20:25:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eabd6b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T20:33:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eabd6b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-21T20:53:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: eabd6b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant · 2023-02-22T18:05:45Z

/bot run all

…ng/sagemaker-python-sdk into update-hf-pt-train-dlc

JingyaHuang · 2023-03-01T18:08:31Z

@tejaschumbalkar @trajanikant Hi folks, I updated the python version as the log mentioned. But the CIs seems somehow stalled. Do you have any idea? Thx!

tejaschumbalkar · 2023-03-01T18:42:07Z

/bot run all

trajanikant

/bot run all

sagemaker-bot · 2023-03-01T19:35:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 260dae2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:38:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 260dae2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:40:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 260dae2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:45:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 260dae2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JingyaHuang · 2023-03-01T20:25:54Z

Seems that I should now have updated the python version for huggingface_pytorch_training_py_version, just reverted. Now only huggingface_pytorch_latest_training_py_version has been updated to py39.

sagemaker-bot · 2023-03-07T22:13:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9d7456d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T22:17:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9d7456d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T22:22:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9d7456d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T22:41:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9d7456d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run pr, slow-tests

sagemaker-bot · 2023-03-08T01:49:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: af47715
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T02:18:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: af47715
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run all

sagemaker-bot · 2023-03-08T22:33:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 972a60f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T22:41:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 972a60f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T22:43:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 972a60f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T22:49:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 972a60f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-09T00:47:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 972a60f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant · 2023-03-10T00:53:33Z

Hi @JingyaHuang
Can you resolve the conflicts and push back?

JingyaHuang · 2023-03-13T09:33:49Z

Hi @trajanikant, I just updated the branch. Feel free to ping me if any other conflict occurs.

(and sorry for the delay, I was on vacation last week

trajanikant

/bot run all

sagemaker-bot · 2023-03-15T17:54:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4d13345
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-15T18:36:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4d13345
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-15T18:41:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4d13345
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-15T18:42:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4d13345
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-15T18:43:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4d13345
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…age uri (aws#3670)

Update image uri for hf_pt_train

eabd6b7

JingyaHuang requested a review from a team as a code owner February 20, 2023 17:22

JingyaHuang requested review from trajanikant and removed request for a team February 20, 2023 17:22

claytonparnell assigned trajanikant Feb 20, 2023

trajanikant reviewed Feb 21, 2023

View reviewed changes

tejaschumbalkar approved these changes Feb 21, 2023

View reviewed changes

Update image uri for hf_pt_train

3a25ba8

trajanikant force-pushed the update-hf-pt-train-dlc branch from eabd6b7 to 3a25ba8 Compare February 22, 2023 17:51

JingyaHuang and others added 3 commits February 26, 2023 18:38

Merge branch 'update-hf-pt-train-dlc' of https://github.com/JingyaHua…

fd25ea0

…ng/sagemaker-python-sdk into update-hf-pt-train-dlc

update py version

adc46a7

Merge branch 'master' into update-hf-pt-train-dlc

260dae2

trajanikant reviewed Mar 1, 2023

View reviewed changes

only update py for the latest

2c06186

JingyaHuang added 2 commits March 1, 2023 13:36

Update image uri for hf_pt_train

629db47

update py version

af1b8bf

trajanikant reviewed Mar 8, 2023

View reviewed changes

Merge branch 'master' into update-hf-pt-train-dlc

972a60f

trajanikant reviewed Mar 8, 2023

View reviewed changes

Merge branch 'master' into update-hf-pt-train-dlc

7989603

Merge branch 'master' into update-hf-pt-train-dlc

e875364

JingyaHuang added 3 commits March 13, 2023 18:12

Merge branch 'master' into update-hf-pt-train-dlc

0ccc3f7

Merge branch 'master' into update-hf-pt-train-dlc

b01f5dd

Merge branch 'master' into update-hf-pt-train-dlc

4d13345

trajanikant reviewed Mar 15, 2023

View reviewed changes

trajanikant merged commit 3a90ccf into aws:master Mar 15, 2023

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

[Feature - Hugging Face] Update Transformers 4.26 - PyTorch 1.13.1 Im…

6047cf3

…age uri (aws#3670)

JingyaHuang deleted the update-hf-pt-train-dlc branch May 5, 2023 09:50

[Feature - Hugging Face] Update Transformers 4.26 - PyTorch 1.13.1 Image uri #3670

[Feature - Hugging Face] Update Transformers 4.26 - PyTorch 1.13.1 Image uri #3670

Uh oh!

Conversation

JingyaHuang commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 21, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant commented Feb 22, 2023

Uh oh!

JingyaHuang commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tejaschumbalkar commented Mar 1, 2023

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

JingyaHuang commented Mar 1, 2023

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

JingyaHuang commented Feb 20, 2023 •

edited

Loading

codecov-commenter commented Feb 21, 2023 •

edited

Loading

JingyaHuang commented Mar 1, 2023 •

edited

Loading