documentation: Torchrun gpu support documentation change #3698

yl-to · 2023-03-07T00:28:57Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-03-07T00:31:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a1a93d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T00:31:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a1a93d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T00:31:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a1a93d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T00:32:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a1a93d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T01:19:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a1a93d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-03-07T01:21:35Z

Codecov Report

Merging #3698 (0a596c2) into master (9e5dca6) will decrease coverage by 0.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3698      +/-   ##
==========================================
- Coverage   89.79%   89.01%   -0.78%     
==========================================
  Files         980      230     -750     
  Lines       92208    22808   -69400     
==========================================
- Hits        82796    20303   -62493     
+ Misses       9412     2505    -6907

Impacted Files	Coverage Δ
src/sagemaker/pytorch/estimator.py	`92.30% <ø> (ø)`
...ython3.7/site-packages/sagemaker/spark/__init__.py
...on3.7/site-packages/sagemaker/debugger/debugger.py
.../lib/python3.10/site-packages/sagemaker/session.py
...r/cli/compatibility/v2/modifiers/tf_legacy_mode.py
...ackages/sagemaker/amazon/factorization_machines.py
...maker/cli/compatibility/v2/modifiers/predictors.py
.../sagemaker/huggingface/training_compiler/config.py
...ackages/sagemaker/feature_store/dataset_builder.py
...on3.7/site-packages/sagemaker/amazon/record_pb2.py
... and 1201 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

doc/frameworks/pytorch/using_pytorch.rst

sagemaker-bot · 2023-03-07T23:21:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2c618a5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/pytorch/estimator.py

doc/frameworks/pytorch/using_pytorch.rst

sagemaker-bot · 2023-03-07T23:40:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b7db86a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-07T23:54:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 604323a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T00:54:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ad6c87e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T00:54:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ad6c87e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T01:03:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ad6c87e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T01:03:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ad6c87e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T01:33:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ad6c87e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Miyoung <[email protected]>

sagemaker-bot · 2023-03-08T17:39:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0a596c2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T18:27:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0a596c2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T18:29:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T18:33:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T18:57:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0a596c2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni

/bot run all

sagemaker-bot · 2023-03-08T23:00:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T23:03:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T23:07:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T23:09:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0a596c2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-08T23:33:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0a596c2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Miyoung <[email protected]> Co-authored-by: Miyoung Choi <[email protected]>

yl-to requested a review from a team as a code owner March 7, 2023 00:28

yl-to requested review from mufaddal-rohawala and removed request for a team March 7, 2023 00:28

yl-to changed the title ~~Torchrun gpu support documentation change~~ Fix: Torchrun gpu support documentation change Mar 7, 2023

yl-to changed the title ~~Fix: Torchrun gpu support documentation change~~ Doc: Torchrun gpu support documentation change Mar 7, 2023

yl-to changed the title ~~Doc: Torchrun gpu support documentation change~~ documentation: Torchrun gpu support documentation change Mar 7, 2023

mchoi8739 suggested changes Mar 7, 2023

View reviewed changes

doc/frameworks/pytorch/using_pytorch.rst Outdated Show resolved Hide resolved

doc/frameworks/pytorch/using_pytorch.rst Outdated Show resolved Hide resolved

mchoi8739 suggested changes Mar 7, 2023

View reviewed changes

src/sagemaker/pytorch/estimator.py Outdated Show resolved Hide resolved

doc/frameworks/pytorch/using_pytorch.rst Outdated Show resolved Hide resolved

mufaddal-rohawala approved these changes Mar 8, 2023

View reviewed changes

yl-to and others added 7 commits March 8, 2023 09:34

update pytorch documentation for torchrun gpu support

cb47e84

fix: version tag

c50ef5b

update the doc with my suggestions

973f72c

updated pytorch estimator distribution arg docstring

6e4f359

fix non-rendered styles

24ee1b5

add a note

5a10b34

fix: format change

0e2aed4

yl-to and others added 4 commits March 8, 2023 09:34

Update src/sagemaker/pytorch/estimator.py

f57949f

Co-authored-by: Miyoung <[email protected]>

Update doc/frameworks/pytorch/using_pytorch.rst

0e87756

Co-authored-by: Miyoung <[email protected]>

fix: format

dd78a85

format fix

0a596c2

navinsoni force-pushed the torchrun_gpu_doc branch from ad6c87e to 0a596c2 Compare March 8, 2023 17:34

navinsoni reviewed Mar 8, 2023

View reviewed changes

navinsoni merged commit ad4a92a into aws:master Mar 8, 2023

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

documentation: Torchrun gpu support documentation change (aws#3698)

a2d807e

Co-authored-by: Miyoung <[email protected]> Co-authored-by: Miyoung Choi <[email protected]>

documentation: Torchrun gpu support documentation change #3698

documentation: Torchrun gpu support documentation change #3698

Uh oh!

Conversation

yl-to commented Mar 7, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 7, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

navinsoni left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 8, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 7, 2023 •

edited

Loading